feat: 이전글 다음글 바로가기 추가 #278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
imdaxsz
reviewed
Dec 6, 2024
| interface PostNavLinkProps { | ||
| type: '이전' | '다음'; | ||
| category: string; | ||
| postLink: PostLinkData | null; |
There was a problem hiding this comment.
post나 postInfo 같은 이름이 더 좋을 것 같아요. postLink라고 하면 URL string이 와야할 것 같은 느낌이 들어요!
imdaxsz
reviewed
Dec 6, 2024
src/types/community.ts
Outdated
| @@ -1,3 +1,10 @@ | |||
| export interface PostLinkData { | |||
There was a problem hiding this comment.
위에서 얘기한 props랑 관련해서 이것도 이름을 AdjacentPost, SiblingPost 이런 걸로 바꾸면 더 좋지 않을까 싶습니다 !
Deploying abcdedu-frontend-dev with
|
| Latest commit: |
1c1dfb0
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://ed021848.abcdedu-frontend.pages.dev |
| Branch Preview URL: | https://feat-post-navigation-phj.abcdedu-frontend.pages.dev |
타입명이랑 변수명 쓰면서도 애매했는데 수정하니까 훨씬 낫네요 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 개요
포스트 댓글 아래에 이전글 다음글 바로가기 및 목록으로 돌아가는 버튼 추가
🚀 변경사항
피드백 반영 후
🔗 관련 이슈
#275
➕ 기타