feat: 댓글 파일 첨부 구현 #279
Merged
feat: 댓글 파일 첨부 구현 #279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- 반환 타입 string으로 고정
Closed
4 tasks
Deploying abcdedu-frontend-dev with
|
| Latest commit: |
6c4c9ae
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://78103be8.abcdedu-frontend.pages.dev |
| Branch Preview URL: | https://feat-comment-file-cmh.abcdedu-frontend.pages.dev |
PHJoon
reviewed
Dec 11, 2024
| handleClose, | ||
| fileName, | ||
| onSubmit, | ||
| } = useCommmentForm({ postId, comment, toggleEditMode }); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 개요
댓글 파일 첨부 구현
댓글(파일) 수정
이미 생성된 댓글에 첨부된 파일을 삭제하려면 댓글 자체를 삭제해야 합니다.
🚀 변경사항
PostNavigation과 댓글 영역 사이에 간격을 좀 더 크게 했습니다.getFileName예외 처리 추가getFileName예외 처리 추가 이후에useSubClassFileHandler테스트가 실패하는 문제가 있었습니다. fileData.filePresignedUrl이 undefined인 경우에도 함수가 호출되는 것 같아 isPdfFile 값을 수정했습니다. 0c2ee90🔗 관련 이슈
#272
➕ 기타