Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ConstraintLayout Support #73

Open
yeminnhtut opened this issue Dec 27, 2018 · 2 comments
Open

ConstraintLayout Support #73

yeminnhtut opened this issue Dec 27, 2018 · 2 comments

Comments

@yeminnhtut
Copy link

yeminnhtut commented Dec 27, 2018

Currently, Shimmer Layout extends from FrameLayout.

So, if I am using ConstraintLayout, I need to wrap every component that I want to Shimmer into ShimmerLayout which I believe is not a good implementation as it increases layout hierarchy.

I believe it'd also be helpful for other devs using the library along with ConstraintLayout.

Thanks for the awesome library.

Cheers 🍻

@veghtomi
Copy link
Contributor

Hi @YMHtut, thanks for the feature idea, it sounds really useful. I will put it on my agenda!

@kuFEAR
Copy link

kuFEAR commented Jan 23, 2019

Or move the shimmer logic into a delegate, like in library for ability to combine few features in one ViewGroup

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants