Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable skipped tests for windows #2583

Open
3 tasks
GiladShoham opened this issue Apr 14, 2020 · 0 comments
Open
3 tasks

enable skipped tests for windows #2583

GiladShoham opened this issue Apr 14, 2020 · 0 comments

Comments

@GiladShoham
Copy link
Member

GiladShoham commented Apr 14, 2020

There are many tests currently disabled for windows:

  • all tests against the local registry (verdaccio) (see SKIP_REGISTRY_TESTS: true env variable on windows_e2e config for circle)
  • all tests against bit.dev servers (see SKIP_BIT_DEV_TESTS: true env variable on windows_e2e config for circle
  • all tests with the following structure:
if (IS_WINDOWS || process.env.APPVEYOR === 'True') {
      // @ts-ignore
      this.skip;
    } 

The registry tests are disabled mainly because the npm add user command to authenticate against the local server is interactive so we used expect which is a Linux tool to enter the credentials.
This might be replaced by npm-cli-login.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants