Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynamic on-chain donation address #109

Open
dadofsambonzuki opened this issue Sep 19, 2023 · 9 comments
Open

Dynamic on-chain donation address #109

dadofsambonzuki opened this issue Sep 19, 2023 · 9 comments
Assignees
Labels
enhancement New feature or request

Comments

@dadofsambonzuki
Copy link
Member

Use the LNBits 'api_fresh_address_watchonly' API to get dynamic on-chain addresses for donations.

@secondl1ght secondl1ght self-assigned this Sep 25, 2023
@secondl1ght secondl1ght added enhancement New feature or request ready for dev Ready to be worked on labels Sep 25, 2023
@dadofsambonzuki
Copy link
Member Author

We now have an issue with large gaps between addresses, which causes issues with wallets.

Need to re-think the strategy here, perhaps using a pool of addresses (maybe randomly served on page load), which are refreshed periodically.

@dadofsambonzuki
Copy link
Member Author

Or maybe silent payments or paynyms are the answer?

@secondl1ght
Copy link
Member

Maybe we can put in an issue with lnbits to add a new getNextUnusedAddress API endpoint. Seems like it should be an option there instead of always grabbing a new one.

@dadofsambonzuki
Copy link
Member Author

Great idea. I can do that.

@dadofsambonzuki dadofsambonzuki removed the ready for dev Ready to be worked on label May 16, 2024
@dadofsambonzuki
Copy link
Member Author

Done..

In the meantime perhaps we could just have a button that generates an address when clicked rather than upon page load?

@dadofsambonzuki
Copy link
Member Author

@dadofsambonzuki
Copy link
Member Author

dadofsambonzuki commented Jun 4, 2024

I think we need to progress with the button to generate an address ASAP @secondl1ght. Loading the wallet with these large gaps is almost impossible right now! Now upto address 4600.

We can show our paynym on the initial page serve: +fragrantcake292

@secondl1ght
Copy link
Member

secondl1ght commented Jun 5, 2024

Yeah we get around 650 views on that page per month so that is the rate the gap will increase. Keep in mind this won't solve the current gaps though and there still may be gaps in the future, but not as many.

@secondl1ght
Copy link
Member

I guess the other option is to go back to the static address.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants