Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynamic Merchant Page OG Image #146

Open
Tracked by #150
dadofsambonzuki opened this issue May 14, 2024 · 6 comments
Open
Tracked by #150

Dynamic Merchant Page OG Image #146

dadofsambonzuki opened this issue May 14, 2024 · 6 comments
Labels
enhancement New feature or request question Further information is requested

Comments

@dadofsambonzuki
Copy link
Member

dadofsambonzuki commented May 14, 2024

The OG image for the merchant page should either:

a) be specific to the merchant category;

b) be dynamically generated with a pin on the map, perhaps with the pin representing the merchant category.

@dadofsambonzuki
Copy link
Member Author

I think I prefer b) as it's more useful and easier to implement and maintain.

@secondl1ght
Copy link
Member

Yeah we can dynamically generate the location of the merchant with a pin on the map - I guess the question is, should there be other elements incorporated into the design like the merchant's name etc. Or just have a full size image of the map?

@secondl1ght
Copy link
Member

The title of the link already has the name of the merchant, so maybe it's not needed? If we do end up going with only the map as the image then maybe we don't actually need a design for this.

@dadofsambonzuki
Copy link
Member Author

Yeah, the title is already enough I think.

Just a map with the usual merchant type specific pin.

This might help: https://docs.stadiamaps.com/static-maps/

There are options in there for caching and also for labelling (if we want to see what a pin label looks like easily).

@dadofsambonzuki dadofsambonzuki added enhancement New feature or request and removed design needed Design needed labels May 15, 2024
@secondl1ght
Copy link
Member

secondl1ght commented May 15, 2024

Ok sounds like we will keep this pretty simple. If we want the style and pin to match what users see on the main map I think we will have to do this in-house. If we don't care about it showing the same type of pin and icon we could use something like Stadia.

@dadofsambonzuki
Copy link
Member Author

Pin should represent merchant category like the main map.

@secondl1ght secondl1ght added question Further information is requested wontfix This will not be worked on and removed wontfix This will not be worked on labels May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants