Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Duplicate mutex in Android #30

Open
graycatdeveloper opened this issue Nov 9, 2023 · 1 comment
Open

Duplicate mutex in Android #30

graycatdeveloper opened this issue Nov 9, 2023 · 1 comment

Comments

@graycatdeveloper
Copy link

Why do you need a copy of mutex in AudioBuffer on Android, if it is native? The call will be blocked anyway. And it's easier to make static mutex for thread safety.
@teamclouday
Copy link
Owner

Yea I see your point. It's more like a personal preference. Is there any performance related issues if I'm not making it static? I assume oboe will prevent recording start twice so there'll be only one mutex each time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@teamclouday @graycatdeveloper