Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

메모리얼 v2 API 개발 및 QueryDSL 도입 #2

Open
3 tasks done
Queue-ri opened this issue Nov 24, 2023 · 0 comments
Open
3 tasks done

메모리얼 v2 API 개발 및 QueryDSL 도입 #2

Queue-ri opened this issue Nov 24, 2023 · 0 comments
Assignees
@hyojeongchoi @nusuy @chaeeun-Han @Queue-ri
Labels
feature New feature refactor Let's make it clean

Comments

@Queue-ri
Copy link
Member

Queue-ri commented Nov 24, 2023 •
edited
Loading

  • v2 API 개발: Controller, Service 분리
    • 리팩토링 전후를 비교하기 위함 (git 히스토리 보는걸로는 한계가 있음)
  • N+1 문제 발생 확인
  • QueryDSL 메소드 작성
@Queue-ri Queue-ri added refactor Let's make it clean feature New feature labels Nov 25, 2023
chaeeun-Han added a commit that referenced this issue Nov 26, 2023
@chaeeun-Han
chore: Add QueryDSL (#2) | Co-authored-by: hyojeongchoi <hyojeong113@…
a3f5fc5 
…naver.com>

Co-authored-by: nusuy <[email protected]>
Co-authored-by: Queue-ri <[email protected]>
chaeeun-Han added a commit that referenced this issue Nov 26, 2023
@chaeeun-Han @hyojeongchoi
@nusuy @Queue-ri
chore: Add QueryDSL (#2)
f7a00bb 
Co-authored-by: hyojeongchoi <[email protected]>
Co-authored-by: nusuy <[email protected]>
Co-authored-by: Queue-ri <[email protected]>
chaeeun-Han added a commit that referenced this issue Nov 26, 2023
@chaeeun-Han @hyojeongchoi
@nusuy @Queue-ri
chore: Add QueryDSL (#2)
7ab83d5 
Co-authored-by: hyojeongchoi <[email protected]>
Co-authored-by: nusuy <[email protected]>
Co-authored-by: Queue-ri <[email protected]>
chaeeun-Han added a commit that referenced this issue Nov 26, 2023
@chaeeun-Han @hyojeongchoi
@nusuy @Queue-ri
refactor: Add MemorialV2Controller (#2)
520e0cc 
Co-authored-by: hyojeongchoi <[email protected]>
Co-authored-by: nusuy <[email protected]>
Co-authored-by: Queue-ri <[email protected]>
chaeeun-Han added a commit that referenced this issue Nov 26, 2023
@chaeeun-Han @hyojeongchoi
@nusuy @Queue-ri
refactor: Add Post-Comment association (#2)
b82de5d 
Co-authored-by: hyojeongchoi <[email protected]>
Co-authored-by: nusuy <[email protected]>
Co-authored-by: Queue-ri <[email protected]>
chaeeun-Han added a commit that referenced this issue Nov 26, 2023
@chaeeun-Han @hyojeongchoi
@nusuy @Queue-ri
refactor: Remove PostId from CommentRequestDto (#2)
8db979e 
Co-authored-by: hyojeongchoi <[email protected]>
Co-authored-by: nusuy <[email protected]>
Co-authored-by: Queue-ri <[email protected]>
chaeeun-Han added a commit that referenced this issue Nov 26, 2023
@chaeeun-Han @hyojeongchoi
@nusuy @Queue-ri
refactor: Modify PostId from CommentMetaDto (#2)
3d09e5c 
Co-authored-by: hyojeongchoi <[email protected]>
Co-authored-by: nusuy <[email protected]>
Co-authored-by: Queue-ri <[email protected]>
chaeeun-Han added a commit that referenced this issue Nov 26, 2023
@chaeeun-Han @hyojeongchoi
@nusuy @Queue-ri
refactor: Remove PostId from MemorialService (#2)
507ebbb 
Co-authored-by: hyojeongchoi <[email protected]>
Co-authored-by: nusuy <[email protected]>
Co-authored-by: Queue-ri <[email protected]>
chaeeun-Han added a commit that referenced this issue Nov 26, 2023
@chaeeun-Han @hyojeongchoi
@nusuy @Queue-ri
refactor: Modify PostId from MyPageService (#2)
3c8b121 
Co-authored-by: hyojeongchoi <[email protected]>
Co-authored-by: nusuy <[email protected]>
Co-authored-by: Queue-ri <[email protected]>
chaeeun-Han added a commit that referenced this issue Nov 26, 2023
@chaeeun-Han @hyojeongchoi
@nusuy @Queue-ri
refactor: Add MemorialV2Service (#2)
24c1fad 
Co-authored-by: hyojeongchoi <[email protected]>
Co-authored-by: nusuy <[email protected]>
Co-authored-by: Queue-ri <[email protected]>
nusuy added a commit that referenced this issue Dec 3, 2023
@nusuy @chaeeun-Han
@Queue-ri @hyojeongchoi
refactor: Add column name to post entity id (#2)
f347b34 
Co-authored-by: chaeeun-Han <[email protected]>
Co-authored-by: Queue-ri <[email protected]>
Co-authored-by: hyojeongchoi <[email protected]>
nusuy added a commit that referenced this issue Dec 3, 2023
@nusuy @chaeeun-Han
@Queue-ri @hyojeongchoi
refactor: Add service user & post associations to comment entity (#2)
165e35c 
Co-authored-by: chaeeun-Han <[email protected]>
Co-authored-by: Queue-ri <[email protected]>
Co-authored-by: hyojeongchoi <[email protected]>
chaeeun-Han added a commit that referenced this issue Dec 3, 2023
@chaeeun-Han @nusuy
@Queue-ri @hyojeongchoi
feat: Add QuerydslConfig (#2)
27d98cb 
Co-authored-by: nusuy <[email protected]>
Co-authored-by: Queue-ri <[email protected]>
Co-authored-by: hyojeongchoi <[email protected]>
chaeeun-Han added a commit that referenced this issue Dec 3, 2023
@chaeeun-Han @nusuy
@Queue-ri @hyojeongchoi
feat: Add CommentRepositoryCustom (#2)
789ccd1 
Co-authored-by: nusuy <[email protected]>
Co-authored-by: Queue-ri <[email protected]>
Co-authored-by: hyojeongchoi <[email protected]>
chaeeun-Han added a commit that referenced this issue Dec 3, 2023
@chaeeun-Han @nusuy
@Queue-ri @hyojeongchoi
feat: Add CommentRepositoryImpl (#2)
193a50e 
Co-authored-by: nusuy <[email protected]>
Co-authored-by: Queue-ri <[email protected]>
Co-authored-by: hyojeongchoi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hyojeongchoi hyojeongchoi

@nusuy nusuy

@chaeeun-Han chaeeun-Han

@Queue-ri Queue-ri

Labels
feature New feature refactor Let's make it clean
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@hyojeongchoi @nusuy @chaeeun-Han @Queue-ri