Config key names

[harold]

I woke this morning and realized these keywords are sort of unfortunately named:

tech.io.azure/src/tech/io/azure/storage_account.clj

Lines 13 to 16 in 55e795e

	(let [account-name (or (:tech.azure.blob/account-name options)
	(config/unchecked-get-config :azure-blob-account-name))
	account-key (or (:tech.azure.blob/account-key options)
	(config/unchecked-get-config :azure-blob-account-key))

They aren't blob specific at all. The name/key pair actually belong to the storage account.

So, better would be:

(config/get-config :azure-storage-account-name)
(config/get-config :azure-storage-account-key)

Drawn from environment variables:

AZURE_STORAGE_ACCOUNT_NAME
AZURE_STORAGE_ACCOUNT_KEY

Unfortunately, I think this change would necessitate kind of a lot of changes in the forecast:

• Code changes where these are read
• Secrets injected into the kube cluster for cron jobs and staging site?
• Secrets injected into prod app service

[harold]

This exists, but as of today we're living with it and working around it.