Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

:result-datatype is unused in invert-categorical-map #423

Open
behrica opened this issue Sep 15, 2024 · 1 comment
Open

:result-datatype is unused in invert-categorical-map #423

behrica opened this issue Sep 15, 2024 · 1 comment

Comments

@behrica
Copy link
Contributor

behrica commented Sep 15, 2024

When transforming the categorical columns of a datset to numeric via ds/categorical->number the attached categorical map contains a field "result-datatype". (and it can be specified manaully as well)

This is unused when we transform "back" using the function 'reverse-map-categorical-xforms' which uses
'invert-categorical-map'

Not sure, if this is a bug or only misleading to me.

It is true that the "pair" of:

``` `fit-categorical-map
transform-categorical-map``

uses it
But these seem to be two different path ways.

@behrica
Copy link
Contributor Author

behrica commented Sep 15, 2024

I should maybe add, that I use exclusively the pair of functions:

tech.v3.dataset/categorical->number
tech.v3.dataset.categorical/reverse-map-categorical-xforms

as both take a dataset as input, which matches "my use cases" of categorical columns for ML.

(I was alreday wondering, why there is not function tech.v3.dataset/reverse-map-categorical-xforms)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant