Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve escape within Drawer / Dialog / etc #31

Closed
techniq opened this issue Nov 9, 2022 · 1 comment
Closed

Improve escape within Drawer / Dialog / etc #31

techniq opened this issue Nov 9, 2022 · 1 comment

Comments

@techniq
Copy link
Owner

techniq commented Nov 9, 2022

Since on:keydown will only bubble to the Drawer from a focusable element within the drawer, we might want to consider adding an invisible input and give initial focus to it.

Using dialog.showModal can help here, but there are also tradeoffs that might not be worth it.
@techniq
Copy link
Owner Author

techniq commented Nov 15, 2022

resolved via d9bdbc1

@techniq techniq closed this as completed Nov 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@techniq