Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Metallb webhook-service renamed to metallb-webhook-service #487

Closed
black-dragon74 opened this issue Mar 26, 2024 · 5 comments · May be fixed by #528
Closed

Metallb webhook-service renamed to metallb-webhook-service #487

black-dragon74 opened this issue Mar 26, 2024 · 5 comments · May be fixed by #528
Labels
wontfix This will not be worked on

Comments

@black-dragon74
Copy link

While deploying the manifests for MetalLB version v0.14.4, the wehbhook-service is named metallb-webhook-service.

This causes the post task to fail with an error.

Posting it here for anyone else facing the same. I can send a PR for the same.

It would make sense to dynamically set a var for service name depending of the config values: metal_lb_*_tag_version.

WDYT @timothystewart6 ?

Regards
@black-dragon74 black-dragon74 changed the title Metallb webhook-service changed to metallb-webhook-service Metallb webhook-service renamed to metallb-webhook-service Mar 26, 2024
@timothystewart6
Copy link
Contributor

timothystewart6 commented Apr 3, 2024 •
edited
Loading

Hey! I am confused on how this is happening? Is this in an upgrade scenario? Or using an old tag with the latest playbook?

@tfs
Copy link

tfs commented Apr 3, 2024 •
edited
Loading

Hey! I am confused on how this is happening? Is this in an upgrade scenario? Or using an old tag with the latest playbook?

Happened to me, too. Scenario for me: changed the version for metallb in the all.yml in my inventory. Redeployed the cluster by running the playbook.

@black-dragon74
Copy link
Author

Hey! I am confused on how this is happening? Is this in an upgrade scenario? Or using an old tag with the latest playbook?

They changed the webhook service name starting with v0.14.4 (added metallb prefix) to more accurately denote where the service comes from.

@timothystewart6
Copy link
Contributor

timothystewart6 commented Apr 4, 2024 •
edited
Loading

Got it. Hmmm.... Not sure I want to make any changes since this is a point in time, otherwise we would have to account for every breaking change with every included dependency. We always ensure that the current configuration works on clean machines (since we run it in CI). Generally speaking (although it does work) upgrading using the playbook is kind of an edge case since we recommend using helm or gitops to handle this after the cluster is bootstrapped.

If you're saying that it's broken in the latest version of Metal LB, happy to review a PR for it!

@timothystewart6 timothystewart6 added the wontfix This will not be worked on label Apr 26, 2024
Open
6 tasks
@konstantin-kornienko
Copy link

Trying to fix this issue, faced it too.
https://github.com/techno-tim/k3s-ansible/pull/528/files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
wontfix This will not be worked on
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Added support for metallb >= 0.14.4 konstantin-kornienko/k3s-ansible
4 participants
@tfs @timothystewart6 @black-dragon74 @konstantin-kornienko