Bump version of reply and clojure-complete #2398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice turnaround! :) 👍 |
|
Looks good; thanks. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes #2380 . clojure-complete "0.2.5" is released with the fix and reply is also released with the updated clojure-complete library as "0.3.8". This PR bumps the version of clojure-complete and reply. Tested it locally and it's working fine now.
Just saw a PR (#2397) that only upgrades reply version. I tested that PR and it still causes the NPE. Though clojure-complete is not used directly I don't know why an older version causes error with reply upgraded. have upgraded both and let me know if there is any place I have missed.
cc @venantius