Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable CONNECT w/ response body tests with excon adapter #2

Open
technoweenie opened this issue Apr 19, 2019 · 0 comments
Open

Enable CONNECT w/ response body tests with excon adapter #2

technoweenie opened this issue Apr 19, 2019 · 0 comments

Comments

@technoweenie
Copy link
Owner

This is different than the httpclient error (#1). The response returns 200, but the body is empty. Looks like a consequence of how Go's HTTP server handles CONNECT requests.

  1) Faraday with HTTP server behaves like a connection making requests with excon: #CONNECT behaves like an idempotent request sends User-Agent request header
     Failure/Error: JSON.parse(response.body)

     JSON::ParserError:
       767: unexpected token at ''
     Shared Example Group: "any request expecting a response body" called from ./spec/support/request_examples.rb:51
     Shared Example Group: "an idempotent request" called from ./spec/support/request_examples.rb:19
     Shared Example Group: "a connection making requests" called from ./spec/insecure_spec.rb:5
     # ./spec/support/request_examples.rb:85:in `block (2 levels) in <top (required)>'
     # ./spec/support/request_examples.rb:97:in `block (3 levels) in <top (required)>'
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant