Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip errors #86

Open
CWBudde opened this issue Aug 18, 2023 · 3 comments
Open

Skip errors #86

CWBudde opened this issue Aug 18, 2023 · 3 comments
Assignees
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@CWBudde
Copy link

CWBudde commented Aug 18, 2023

In case of SQL errors, I would like to skip this table and move on to the next table. This might end in a corrupt database, but it's sometimes easier to fix the errors manually. In my case it's just an issue with an index, which I can easily recreate.

In order to make it clear, I would prefer a custom command-line option "ignore-error" or "force-conversion" with the description that errors will be ignored and the conversion might be incomplete in the end.

I'm willing to implement this by myself in a fork. If so, I'd open a pull request.

@CWBudde CWBudde added the enhancement New feature or request label Aug 18, 2023
@techouse
Copy link
Owner

Hey!

Have you tried any of these options:

  -X, --without-foreign-keys      Do not transfer foreign keys.
  -W, --ignore-duplicate-keys     Ignore duplicate keys. The default behavior
                                  is to create new ones with a numerical
                                  suffix, e.g. 'exising_key' ->
                                  'existing_key_1'

Othrwise I'm not keen on implementing a data corruption feature.

If you want, you can submit a PR.

@CWBudde
Copy link
Author

CWBudde commented Aug 18, 2023

Yes, I have tried both. No success. The PR is on its way. I'm currently testing it.

@techouse
Copy link
Owner

I'm currently testing it.

Don't forget about unit tests 😇

@techouse techouse assigned CWBudde and unassigned techouse Oct 8, 2023
@techouse techouse added the help wanted Extra attention is needed label Oct 8, 2023
@techouse techouse linked a pull request Nov 15, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants