Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Submit before_record_interaction to VCRpy to replace CleanYAMLSerializer #4

Closed
zdc217 opened this issue Jan 18, 2023 · 3 comments
Closed

Comments

@zdc217
Copy link
Contributor

zdc217 commented Jan 18, 2023

Discussing with @ddriddle:

The CleanYAMLSerializer code is a work around for before_record_response to allow us to access the request to match the URI. Should we consider contributing code to VCRpy that adds access to the request to the before_record_response param?

Another approach might be to add something like before_record_interaction that would give access to the response and the request.

@zdc217 zdc217 changed the title Pull request for VCRpy? Submit before_record_interaction to VCRpy to replace CleanYAMLSerializer Jan 18, 2023
@zdc217
Copy link
Contributor Author

zdc217 commented Jan 18, 2023

Per team discussion, Ed approves and we should do this

Similar issues have been submitted. We could potentially close those out by contributing this code to VCRpy

kevin1024/vcrpy#556
kevin1024/vcrpy#527

@edthedev
Copy link
Contributor

Code update and test are created at https://github.com/zdc217/vcrpy/tree/feature/before_record_interaction

We need to submit a pull request.

@tzturner
Copy link
Contributor

Pull request put in here!
kevin1024/vcrpy#679

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants