In some circumstances the build file process is not properly returning PSScriptAnalyzer violations

[techthoughts2]

Expected Behavior

Analyze build tasks should always return any PSScriptAnalyzer violations

Current Behavior

In some circumstances the Analyze build task returns null even though individual files have known PSScriptAnalyzer violations

Possible Solution

This is likely due to the way that the $scriptAnalyzerResults is being loaded.

Switching to a list context seems to solve the problem:

$analyzerResults = New-Object System.Collections.Generic.List[Microsoft.Windows.PowerShell.ScriptAnalyzer.Generic.DiagnosticRecord]
foreach ($file in $filesToAnalyze) {
    $results = $null
    $results = Invoke-ScriptAnalyzer -Path $file.FullName
    if ($results) {
        foreach ($result in $results) {
            $analyzerResults.Add($result)
        }
    }
}

[SamErde]

Happy to test this. The example looks very different from the structure of the analyze tasks in the {ModuleName}.build.ps1 script, though. Do you have a test branch where that is updated?

[techthoughts2]

I should have been more clear in the bug description.
This bug isn't impacting the downstream use of Catesta.
If you use Catesta to build a module, the build file will reliably run PSScriptAnalyzer in the newly created module.

This bug is specific to the build file for building the Catesta module itself. This is due to some of the unique characteristics of Catesta containing the resource files (including tests) inside of src/Catesa/Resources.

I should have a fix up shortly. But users of Catesta are not impacted by this bug.

[SamErde]

Gotcha. That makes sense now. 😀