Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Directive: mark-non-leaf #231

Closed
LecrisUT opened this issue Apr 16, 2024 · 0 comments · Fixed by #223
Closed

Directive: mark-non-leaf #231

LecrisUT opened this issue Apr 16, 2024 · 0 comments · Fixed by #223
Assignees
Milestone

Comments

@LecrisUT
Copy link
Contributor

#223 is introducing mark-leaf as a mechanism to make a directory fmf file into a leaf, e.g. with /root/leaf_test (e.g. from /root/leaf_test.fmf) it allows /root to also be a valid test. This proposal is to also support the opposite, i.e. if we have a file /root.fmf do not expand it as a leaf.

This is relevant when we consider graft mechanism in #99, and specifically when one of the trees is virtual (generated from discover step). E.g. if the generated tree is like /root/leaf_test_A, /root/leaf_test_B, we could have a /root.fmf file such that it is inherited in all leaf_test_*. The issue is that currently /root would be considered as a leaf, and can affect tmt lint or define dummy tests for other discover steps. Having this mechanism will effectively hide the /root base, until it is expanded by leaves (through graft mechanism).

lukaszachy added a commit that referenced this issue May 16, 2024
Expected usage with virtual tests while keeping the parent
test as well as hiding leaf nodes from selection

Fix: #221
Fix: #231
@lukaszachy lukaszachy linked a pull request May 16, 2024 that will close this issue
3 tasks
@psss psss added this to the 1.4 milestone Jun 4, 2024
@psss psss closed this as completed in d9aee8e Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants