-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Broken link in tmt documentation #2868
Comments
I ran a script to get the broken link for the docs: for j in $(for i in $(find -name '*html' );do curl localhost:8000/$i |xmllint --xpath '//a' --html -;done 2>/dev/null|grep '\"https://[^\"]*\"' -o|sed 's/\"//g'|sort|uniq);
do curl -sI $j|head -1|grep -q 404;
if [ $? -eq 0 ];
then echo $j ;
fi ;
done Results:
I'd like to fix them |
@qiankehan FYI, there's a PR to add linkcheck Sphinx engine, #2489. It should reveal very similar issues. Invalid links to tests like the Maybe we should move the logic mapping links to actual URLs into the Python code in https://github.com/teemtee/tmt/blob/main/docs/scripts/generate-stories.py, as a function, and inject it into the template environment. The function we could then test - I'd worry that by fixing one case we may easily break something else, and unit tests would be very helpful. |
Related to #2489. This PR does not fix all invalid links, but the rest should be caused by incorrect handling of links in a template when rendering them; these should be resolved by the work related to #2868. Co-authored-by: Miroslav Vadkerti <[email protected]>
Related to #2489. This PR does not fix all invalid links, but the rest should be caused by incorrect handling of links in a template when rendering them; these should be resolved by the work related to #2868. Co-authored-by: Miroslav Vadkerti <[email protected]>
I believe #3001 resolves all remaining broken links. |
I found out that the links meant to link to FMF files do not link correctly. Instead of linking to the FMF file, they link to a folder.
E.g. here in try documentation the link /tests/try
The text was updated successfully, but these errors were encountered: