Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature schema missing name, order #2984

Closed
martinhoyer opened this issue Jun 3, 2024 · 2 comments · Fixed by #3225
Closed

Feature schema missing name, order #2984

martinhoyer opened this issue Jun 3, 2024 · 2 comments · Fixed by #3225
Assignees
Labels
code | no functional change "No Functional Change" intended. Patch should not change tmt's behavior in any way. code | trivial A simple patch - a couple of lines, an easy-to-understand change, a typo fix. command | lint tmt lint command good first issue Good for newcomers
Milestone

Comments

@martinhoyer
Copy link
Collaborator

tmt lint reporting false positives when order or name is added to feature prepare steps.

@martinhoyer martinhoyer added good first issue Good for newcomers command | lint tmt lint command code | no functional change "No Functional Change" intended. Patch should not change tmt's behavior in any way. code | trivial A simple patch - a couple of lines, an easy-to-understand change, a typo fix. labels Jun 3, 2024
@LecrisUT
Copy link
Contributor

LecrisUT commented Jun 3, 2024

Probably the schema files should be refactored a bit to use definitions and one_of. Maybe could try:

definitions:
  feature:
    properties:
      how:
        type: string
        enum:
          - feature
      epel:
        type: string
        enum:
          - enabled
          - disabled
one_of:
  - $ref: "/schemas/core#/definitions/core"
  - $ref: "#/definitions/feature"
required:
  - how

Dunno how well these mix though, particularly required over there. Having some reference would definitely be helpful for plugin development.

@psss psss added this to the 1.35 milestone Jun 25, 2024
@psss psss changed the title Feature schema missing name, order. Feature schema missing name, order Jun 25, 2024
@martinhoyer martinhoyer modified the milestones: 1.35, 1.36 Jul 30, 2024
@martinhoyer martinhoyer modified the milestones: 1.36, 1.37 Sep 4, 2024
@psss
Copy link
Collaborator

psss commented Sep 20, 2024

Probably the schema files should be refactored a bit to use definitions and one_of.

Looks like a good idea. Let's cover that in a separate pull request.

@psss psss changed the title Feature schema missing name, order Add missing where, name and order keywords into schema Sep 20, 2024
@psss psss changed the title Add missing where, name and order keywords into schema Feature schema missing name, order Sep 20, 2024
@psss psss linked a pull request Sep 20, 2024 that will close this issue
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code | no functional change "No Functional Change" intended. Patch should not change tmt's behavior in any way. code | trivial A simple patch - a couple of lines, an easy-to-understand change, a typo fix. command | lint tmt lint command good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants