Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Require setuptools #3221

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Require setuptools #3221

wants to merge 1 commit into from

Conversation

happz
Copy link
Collaborator

@happz happz commented Sep 17, 2024

tmt depends on pkg_resources package shipped by setuptools, but it seems setuptools may be missing in some virtualenvs, not being installed by default.

Pull Request Checklist

  • implement the feature
  • write the documentation
  • extend the test coverage
  • update the specification
  • adjust plugin docstring
  • modify the json schema
  • mention the version
  • include a release note

@happz
Require setuptools
ebe86a1 
tmt depends on `pkg_resources` package shipped by `setuptools`, but it
seems `setuptools` may be missing in some virtualenvs, not being
installed by default.
@happz happz added packaging Changes related to the rpm packaging ci | full test Pull request is ready for the full test execution labels Sep 17, 2024
@happz
Copy link
Collaborator Author

happz commented Sep 17, 2024

/packit test

@LecrisUT
Copy link
Contributor

Why the dependency?

@happz
Copy link
Collaborator Author

happz commented Sep 17, 2024

Why the dependency?

mrack fails to import without pkg_resources. But as I read it now, I mistook pkg_resources for something else, tmt does not depend on it.

@LecrisUT
Copy link
Contributor

mrack fails to import without pkg_resources

Seems to be in the beaker project instead: https://github.com/search?q=repo%3Abeaker-project%2Fbeaker%20pkg_resources&type=code. That thing needs to be patched asap, I've opened an issue upstream about it: beaker-project/beaker#232

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@psss psss Awaiting requested review from psss psss will be requested when the pull request is marked ready for review psss is a code owner

@lukaszachy lukaszachy Awaiting requested review from lukaszachy lukaszachy will be requested when the pull request is marked ready for review lukaszachy is a code owner

@thrix thrix Awaiting requested review from thrix thrix will be requested when the pull request is marked ready for review thrix is a code owner

@janhavlin janhavlin Awaiting requested review from janhavlin janhavlin will be requested when the pull request is marked ready for review janhavlin is a code owner

@martinhoyer martinhoyer Awaiting requested review from martinhoyer martinhoyer will be requested when the pull request is marked ready for review martinhoyer is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
ci | full test Pull request is ready for the full test execution packaging Changes related to the rpm packaging
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@happz @LecrisUT