Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Broken makefile #8436

Open
xinnjie opened this issue Dec 14, 2024 · 3 comments
Open

Broken makefile #8436

xinnjie opened this issue Dec 14, 2024 · 3 comments
Assignees
@RenuBhati
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/bug Categorizes issue or PR as related to a bug.

Comments

@xinnjie
Copy link

xinnjie commented Dec 14, 2024

Expected Behavior

make goimports should work correctly.

Actual Behavior

goimports installation failed

(base) ➜  pipeline git:(main) make goimports    
🐱 building golang.org/x/tools/cmd/goimports…
go: modules disabled by GO111MODULE=off; see 'go help modules'
make: *** [/Users/xinnjie/Dev/tekton/pipeline/.bin/goimports] Error 1
(base) ➜  pipeline git:(main) go version
go version go1.22.10 darwin/arm64

Steps to Reproduce the Problem

  1. Delete .bin/goimports
  2. make goimports

Tools like ineffassign, staticcheck, dupl, and errcheck can be removed from the Makefile.

The goimports installation can either be fixed or removed, as it's verifiable via golangci-lint. However, its presence is convenient since make goimports resolves all import issues.
@xinnjie xinnjie added the kind/bug Categorizes issue or PR as related to a bug. label Dec 14, 2024
@vdemeester vdemeester added help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. labels Dec 17, 2024
@RenuBhati
Copy link

Hi @vdemeester I would like to work on this issue. Can you please assign me this?

@RenuBhati RenuBhati mentioned this issue Dec 30, 2024
Open
8 tasks
@RenuBhati
Copy link

Hi, I submitted a PR please review.
Thanks.

@vdemeester
Copy link
Member

/assign @RenuBhati

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@RenuBhati RenuBhati

Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@vdemeester @xinnjie @RenuBhati