Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed make goimports #8461

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fixed make goimports #8461

wants to merge 1 commit into from

Conversation

RenuBhati
Copy link

@RenuBhati RenuBhati commented Dec 30, 2024

Changes

Addresses: #8436

Added version-aware installation of goimports:

For Go < 1.16: Uses existing PACKAGE-based installation method
For Go ≥ 1.16: Uses modern go install @latest syntax

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Has Docs if any changes are user facing, including updates to minimum requirements e.g. Kubernetes version bumps
  • Has Tests included if any functionality added or changed
  • pre-commit Passed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including functionality, content, code)
  • Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings). See some examples of good release notes.
  • Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

NONE

@tekton-robot tekton-robot added the release-note-none Denotes a PR that doesnt merit a release note. label Dec 30, 2024
Copy link

linux-foundation-easycla bot commented Dec 30, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: RenuBhati / name: Renu Rahul Bhati (f192e7d)

@tekton-robot tekton-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 30, 2024
@tekton-robot
Copy link
Collaborator

Hi @RenuBhati. Thanks for your PR.

I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@RenuBhati
Copy link
Author

RenuBhati commented Dec 30, 2024

CLA Not Signed

@dibyom @vdemeester can you please help here? I am student, how should I confirm affiliation with a company?

@xinnjie
Copy link

xinnjie commented Dec 31, 2024

CLA Not Signed

@dibyom @vdemeester can you please help here? I am student, how should I confirm affiliation with a company?

Try to check git commit author email is same as your email address of github account.

@xinnjie
Copy link

xinnjie commented Dec 31, 2024

module github.com/tektoncd/pipeline
go 1.22
toolchain go1.22.5

in go.mod

Since we are already using go 1.22 in pipeline project, you could simply remove the condition check.

@RenuBhati
Copy link
Author

RenuBhati commented Jan 2, 2025

module github.com/tektoncd/pipeline
go 1.22
toolchain go1.22.5

in go.mod

Since we are already using go 1.22 in pipeline project, you could simply remove the condition check.

Thanks for pointing that out, I have updated code. Please review.

@vdemeester
Copy link
Member

/kind misc

@tekton-robot tekton-robot added the kind/misc Categorizes issue or PR as a miscellaneuous one. label Jan 2, 2025
Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test

@tekton-robot tekton-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 2, 2025
@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/misc Categorizes issue or PR as a miscellaneuous one. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesnt merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants