Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set our own KUBERNETES_MIN_VERSION #8529

Open
vdemeester opened this issue Jan 24, 2025 · 1 comment
Open

Set our own KUBERNETES_MIN_VERSION #8529

vdemeester opened this issue Jan 24, 2025 · 1 comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@vdemeester
Copy link
Member

The KUBERNETES_MIN_VERSION and knative.dev/pkg/version package are setting which minimum kubernetes version that is supported. If we try to run the controller on an older Kubernetes version, it will panic.

As of today, we inherit this value from knative version.go value. Any time we update the version of knative.dev/pkg this value can change — Knative updates it depending on Kubernetes maintenance support window — and thus we need to take this into account.

These updates are a bit arbitrary from the tektoncd/pipeline point of view as, most of the time, it would still work with older version of Kubernetes. We don't use that much API, most of it is super stable and doesn't change a lot, …

I am creating this issue to discuss if we want to set our own KUBERNETES_MIN_VERSION (and test accordingly) in tektoncd/pipeline.

  • By default tektoncd/pipeline would be installable in a wider range of Kubernetes version (and thus distributions)
  • We decide when we stop "supporting" a given kubernetes version.

cc @afrittoli @tektoncd/core-maintainers @tektoncd/core-collaborators

@vdemeester vdemeester added the kind/question Issues or PRs that are questions around the project or a particular feature label Jan 24, 2025
@afrittoli
Copy link
Member

@vdemeester I've also had this thought on the back of my mind for some time.

Until now, the knative package update has driven this update, but I think it would be a very good idea to have our own, especially now that we have introduced k8s matrix testing.

Since we have a pretty stable release plan for Tekton LTS and k8s has a similar plan, we could probably schedule updates to the k8s min version along with the release plan.

@vdemeester vdemeester added kind/feature Categorizes issue or PR as related to a new feature. and removed kind/question Issues or PRs that are questions around the project or a particular feature labels Jan 24, 2025
@vdemeester vdemeester changed the title Should we set our own KUBERNETES_MIN_VERSION ? Set our own KUBERNETES_MIN_VERSION Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
Status: Todo
Development

No branches or pull requests

2 participants