Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-v0.68.x] .github/workflows: add a build and test workflows #8583

Merged

Conversation

vdemeester
Copy link
Member

Updated the GitHub Actions workflows to improve naming consistency and
add a new yamllint step. Renamed job names for clarity and removed
unnecessary environment variable in e2e-matrix.yml.

Ports most prow jobs into a set of workflows.

/kind misc

Signed-off-by: Vincent Demeester [email protected]
(cherry picked from commit fe892bf)

See #8577

Changes

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Has Docs if any changes are user facing, including updates to minimum requirements e.g. Kubernetes version bumps
  • Has Tests included if any functionality added or changed
  • pre-commit Passed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including functionality, content, code)
  • Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings). See some examples of good release notes.
  • Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

NONE

This commit introduces a new CI workflow in `.github/workflows/ci.yaml` that
handles build, linting, testing, and calls the e2e workflows. It optimizes
the CI pipeline by including caching mechanisms and consolidates previously
separate workflows.

The following changes have been made:
* Added a multi-stage CI workflow named `ci`.
* Introduced linting steps using tools like `gofmt`, `golangci-lint`,
  `yamllint` and `go-license` check.
* Incorporated build, unit tests, and generated code verification.
* Added a multi-arch build support configuration.
* Consolidated end-to-end tests via a workflow call in `e2e-matrix.yml`.

Additionally, the redundant `golangci-lint.yaml` workflow has been removed.
Support for a new test target `test-unit-verbose-and-race` is introduced in
the `Makefile`, and the Go toolchain in `go.mod` is updated from `go 1.22.3`
to `go 1.22.7`.

Signed-off-by: Vincent Demeester <[email protected]>
(cherry picked from commit fe892bf)
@tekton-robot tekton-robot added kind/misc Categorizes issue or PR as a miscellaneuous one. release-note-none Denotes a PR that doesnt merit a release note. labels Feb 19, 2025
@tekton-robot tekton-robot requested review from dibyom and jerop February 19, 2025 12:34
@tekton-robot tekton-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Feb 19, 2025
Copy link
Member

@afrittoli afrittoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: afrittoli

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 19, 2025
@abayer
Copy link
Contributor

abayer commented Feb 19, 2025

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 19, 2025
@abayer
Copy link
Contributor

abayer commented Feb 19, 2025

/lgtm

@tekton-robot tekton-robot merged commit 73b7953 into tektoncd:release-v0.68.x Feb 19, 2025
19 checks passed
@vdemeester vdemeester deleted the 0.68-github-workflows branch February 19, 2025 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/misc Categorizes issue or PR as a miscellaneuous one. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesnt merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants