-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(chart):add KB to link to export example #2124
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The value of this KB is questionable at best as it lacks content. I would suggest reworking it and adding at least the primary steps required to export the Chart as an image. You could of course keep the link to the GitHub project with the complete implementation.
The reasons for the KB appearing as it does are:
If these reasons are not acceptable, I will include the instructions from the GitHub project in the KB. |
We have this type of KB articles for most projects in the blazor-ui repo. Their main purpose is to provide a link to the corresponding project. Indeed, we have previously discussed that such KBs do not have much value. In addition, a lot of the customers do not like the idea of having to browse to the repo and download the app in order to just test the specific scenario. That said, we will have an initiative for extracting all projects to KBs and deprecate the blazor-ui repo. This, however will take time and we better have the KB linking the app until then. |
Hello @ntacheva, Check the below option if you would like to automatically generate PR to production. The automation uses the branch for the cherry-pick, and then will delete the branch. Please, do not delete it manually.
|
@yordan-mitev please let us know if you are ok with the proposed approach |
You are free to add the file as is. This, however, is not an actual KB and has no value.
|
Co-authored-by: Yordan <[email protected]>
Co-authored-by: Yordan <[email protected]>
Here you are the link to your PR to production: 2138 |
Related to: https://github.com/telerik/blazor/issues/7634