Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Could the PR remain in branch instead of merged to master? #268

Open
pivotal-bin-ju opened this issue Sep 15, 2021 · 2 comments
Open

Could the PR remain in branch instead of merged to master? #268

pivotal-bin-ju opened this issue Sep 15, 2021 · 2 comments

Comments

@pivotal-bin-ju
Copy link

I tried to set integration_tool=checkout, but the branch code is still merged to master. I am wondering if there a way to leave the PR in the branch?

I know the old jtarchie works in this flavor, the new resource break our pipeline.

Thanks!

@tremblaysimon
Copy link

If you use a put step, you must use get_params to add integration_tool=checkout parameter otherwise it will be override by the implicit get step done after a put step.

It looks like this in one of my job:

...
    - get: pull-request
    - put: pull-request
      params:
        status: pending
        path: pull-request
      get_params:
        integration_tool: checkout
...

@bgandon
Copy link

bgandon commented May 10, 2024

Glad you found an answer to your issue!

But this would also need an update in the docs, don't you think?

Recent news is that the Cloud Foundry community is now maintaining a fork of this resource at cloudfoundry-community/github-pr-resource.

On our Concourse installation at Gstack, that one is working fine. Could you give a try and submit a PR to the docs there?

(the new resource is a drop-in replacement; you only have to switch telia-ossto cfcommunity in in the resource_types: declaration, i.e. specify repository: cfcommunity/github-pr-resource)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants