Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement message headers #338

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Implement message headers #338

wants to merge 3 commits into from

Conversation

v0idpwn
Copy link
Collaborator

@v0idpwn v0idpwn commented Nov 2, 2024 •
edited
Loading

Closes #203
Needed for #294

@v0idpwn
Implement headers
819fbf2 
Implement message headers
@v0idpwn v0idpwn marked this pull request as ready for review November 2, 2024 18:34
theory
theory requested changes Nov 4, 2024
View reviewed changes
Copy link
Contributor

@theory theory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks straightforward, but please:

  • Add an upgrade script that can upgrade the SQL from the previous version to this version's change. Details here.
  • Add tests for the new functions and behaviors.

Thanks!

@v0idpwn
Copy link
Collaborator Author

v0idpwn commented Nov 4, 2024 •
edited
Loading

Of course, this is an API proposal, not ready yet :)
Sorry, communicated with @ChuckHend but didn't write it in description

@theory
Copy link
Contributor

theory commented Nov 4, 2024

Of course, this is an API proposal, not ready yet :) Sorry, communicated with @ChuckHend but didn't write it in description

Ah, got it, didn't realize, thanks for clarifying.

@theory
Copy link
Contributor

theory commented Nov 4, 2024

(Consider converting this to a Draft PR)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@theory theory theory requested changes

@ChuckHend ChuckHend Awaiting requested review from ChuckHend ChuckHend is a code owner

@vrmiguel vrmiguel Awaiting requested review from vrmiguel vrmiguel is a code owner

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature request: support headers, like ActiveMQ
2 participants
@v0idpwn @theory