Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ld.so.conf.d/tembo.conf to base image (#91) #91

Merged
merged 1 commit into from
Feb 18, 2025
Merged

Conversation

theory
Copy link
Contributor

@theory theory commented Feb 18, 2025

This will allow the persistence of shared libraries currently installed in non-persistent locations like /usr/local/lib. None included so far; see TEM-3045 for details. Resolves TEM-3043.

@theory theory requested a review from nhudson February 18, 2025 19:28
@theory theory self-assigned this Feb 18, 2025
theory added a commit that referenced this pull request Feb 18, 2025
This will allow the persistence of shared libraries currently installed
in non-persistent locations like `/usr/local/lib`. None included so far;
see TEM-3045 for details. Resolves TEM-3043.
theory added a commit that referenced this pull request Feb 18, 2025
This will allow the persistence of shared libraries currently installed
in non-persistent locations like `/usr/local/lib`. None included so far;
see TEM-3045 for details. Resolves TEM-3043.

Also: Fix the naming of the `libduckdb.so` files. Install with the
version appended ot the file name, as specified by [the docs], then let
`lcconfig` create the `libduckdb.so` symlink. The invalid
`libduckdb${DUCKDB_VERSION}.so` name is only required by `duckdb_fdw` at
compile time, so there is no need to include it here.

  [the docs]: https://tldp.org/HOWTO/Program-Library-HOWTO/shared-libraries.html
@theory theory requested a review from nhudson February 18, 2025 21:11
This will allow the persistence of shared libraries currently installed
in non-persistent locations like `/usr/local/lib`. None included so far;
see TEM-3045 for details. Resolves TEM-3043.

Also: Fix the naming of the `libduckdb.so` files. Install with the
version appended ot the file name, as specified by [the docs], then let
`lcconfig` create the `libduckdb.so` symlink. The invalid
`libduckdb${DUCKDB_VERSION}.so` name is only required by `duckdb_fdw` at
compile time, so there is no need to include it here.

  [the docs]: https://tldp.org/HOWTO/Program-Library-HOWTO/shared-libraries.html
@theory theory merged commit 919bcfe into main Feb 18, 2025
1 check passed
@theory theory deleted the tembo-ldconfig branch February 18, 2025 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants