Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Features Platform] Remove TEMPORAL_FEATURES_DISABLE_WORKFLOW_COMPLETION_CHECK workaround #581

Open
dandavison opened this issue Jan 17, 2025 · 0 comments

Comments

@dandavison
Copy link
Contributor

In #577 the env var TEMPORAL_FEATURES_DISABLE_WORKFLOW_COMPLETION_CHECK was introduced to workaround a problem when running tests against cloud. This should be resolved correctly and the env var removed.

The problem is described here

We have a bit of older logic that checks after our tests if any workflows are still running. Repeatedly every 100ms, to a max of 5s, it makes a Go SDK ListOpenWorkflowExecutions + ListClosedWorkflowExecutions call to see if any of the returned workflows have a status of WORKFLOW_EXECUTION_STATUS_RUNNING. If after 5s there is still one with that status, we fail. We saw sometime approx between Oct 10th and Oct 25th, our assertion here started failing in cloud (and still does). The workflows were completing (in milliseconds) but even after 5s these were returning stale data in cloud saying that status was still running.

#579 has updated to use the preferred ListWorkflow API, but the problem remains.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant