Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDK should try to check if activity is completed before sending last buffered heartbeat #608

Open
tsurdilo opened this issue Mar 5, 2025 · 1 comment
Labels
enhancement New feature or request

Comments

@tsurdilo
Copy link

tsurdilo commented Mar 5, 2025

Feature request is for SDKs to try to check if activity completed or timed out before sending last buffered heartbeat. Currently this check is not done which can cause noice in the temporal_request_failure metric

@tsurdilo tsurdilo added the enhancement New feature or request label Mar 5, 2025
@cretz
Copy link
Member

cretz commented Mar 7, 2025

Can you give some more details of the scenario? How can SDK know if an activity is completed or timed out server side before sending the heartbeat? All SDK knows is whether cancel_requested was set on the last heartbeat attempt, SDK can't know if the heartbeat will be rejected ahead of time unless there is a specific scenario you're thinking of that I am forgetting (also feel free to bring up internally if that's easier for you for back-and-forth).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants