From 8256a662bbab085d31eaed9d469e10a73b6f5a9c Mon Sep 17 00:00:00 2001 From: Rob Holland Date: Tue, 30 Jan 2024 12:42:29 +0000 Subject: [PATCH 1/8] Manually triggered release action. --- .github/workflows/publish-charts.yml | 51 ++++++++++++++++++- Chart.yaml => charts/temporal/Chart.yaml | 4 +- .../temporal/templates}/NOTES.txt | 0 .../temporal/templates}/_helpers.tpl | 0 .../templates}/admintools-deployment.yaml | 0 .../templates}/admintools-service.yaml | 0 .../temporal/templates}/server-configmap.yaml | 0 .../templates}/server-deployment.yaml | 0 .../templates}/server-dynamicconfigmap.yaml | 0 .../temporal/templates}/server-job.yaml | 0 .../temporal/templates}/server-pdb.yaml | 0 .../temporal/templates}/server-secret.yaml | 0 .../templates}/server-service-monitor.yaml | 0 .../temporal/templates}/server-service.yaml | 0 .../temporal/templates}/serviceaccount.yaml | 0 .../temporal/templates}/web-configmap.yaml | 0 .../temporal/templates}/web-deployment.yaml | 0 .../temporal/templates}/web-ingress.yaml | 0 .../temporal/templates}/web-service.yaml | 0 values.yaml => charts/temporal/values.yaml | 0 .../temporal/values}/values.antiaffinity.yaml | 0 .../values}/values.archival.filestore.yaml | 0 .../values}/values.archival.gcloud.yaml | 0 .../temporal/values}/values.archival.s3.yaml | 0 .../temporal/values}/values.aurora-mysql.yaml | 0 .../temporal/values}/values.cassandra.yaml | 0 .../values}/values.cloudsqlproxy.yaml | 0 .../values}/values.dynamic_config.yaml | 0 .../values}/values.elasticsearch.yaml | 0 .../temporal/values}/values.mysql.yaml | 0 .../temporal/values}/values.ndc.yaml | 0 .../temporal/values}/values.postgresql.yaml | 0 .../values}/values.prometheus.external.yaml | 0 .../temporal/values}/values.resources.yaml | 0 34 files changed, 51 insertions(+), 4 deletions(-) rename Chart.yaml => charts/temporal/Chart.yaml (98%) rename {templates => charts/temporal/templates}/NOTES.txt (100%) rename {templates => charts/temporal/templates}/_helpers.tpl (100%) rename {templates => charts/temporal/templates}/admintools-deployment.yaml (100%) rename {templates => charts/temporal/templates}/admintools-service.yaml (100%) rename {templates => charts/temporal/templates}/server-configmap.yaml (100%) rename {templates => charts/temporal/templates}/server-deployment.yaml (100%) rename {templates => charts/temporal/templates}/server-dynamicconfigmap.yaml (100%) rename {templates => charts/temporal/templates}/server-job.yaml (100%) rename {templates => charts/temporal/templates}/server-pdb.yaml (100%) rename {templates => charts/temporal/templates}/server-secret.yaml (100%) rename {templates => charts/temporal/templates}/server-service-monitor.yaml (100%) rename {templates => charts/temporal/templates}/server-service.yaml (100%) rename {templates => charts/temporal/templates}/serviceaccount.yaml (100%) rename {templates => charts/temporal/templates}/web-configmap.yaml (100%) rename {templates => charts/temporal/templates}/web-deployment.yaml (100%) rename {templates => charts/temporal/templates}/web-ingress.yaml (100%) rename {templates => charts/temporal/templates}/web-service.yaml (100%) rename values.yaml => charts/temporal/values.yaml (100%) rename {values => charts/temporal/values}/values.antiaffinity.yaml (100%) rename {values => charts/temporal/values}/values.archival.filestore.yaml (100%) rename {values => charts/temporal/values}/values.archival.gcloud.yaml (100%) rename {values => charts/temporal/values}/values.archival.s3.yaml (100%) rename {values => charts/temporal/values}/values.aurora-mysql.yaml (100%) rename {values => charts/temporal/values}/values.cassandra.yaml (100%) rename {values => charts/temporal/values}/values.cloudsqlproxy.yaml (100%) rename {values => charts/temporal/values}/values.dynamic_config.yaml (100%) rename {values => charts/temporal/values}/values.elasticsearch.yaml (100%) rename {values => charts/temporal/values}/values.mysql.yaml (100%) rename {values => charts/temporal/values}/values.ndc.yaml (100%) rename {values => charts/temporal/values}/values.postgresql.yaml (100%) rename {values => charts/temporal/values}/values.prometheus.external.yaml (100%) rename {values => charts/temporal/values}/values.resources.yaml (100%) diff --git a/.github/workflows/publish-charts.yml b/.github/workflows/publish-charts.yml index be3e82f6..338adc41 100644 --- a/.github/workflows/publish-charts.yml +++ b/.github/workflows/publish-charts.yml @@ -13,6 +13,53 @@ jobs: contents: write runs-on: ubuntu-latest steps: - - name: Empty + - name: Generate token + id: generate_token + uses: actions/create-github-app-token@v1 + with: + app-id: ${{ secrets.TEMPORAL_CICD_APP_ID }} + private-key: ${{ secrets.TEMPORAL_CICD_PRIVATE_KEY }} + + - name: Checkout + uses: actions/checkout@v4 + with: + persist-credentials: true + token: ${{ steps.generate_token.outputs.token }} + ref: rh-chart-publish + fetch-depth: 0 + fetch-tags: true + + - name: Configure Git + run: | + git config --local user.name 'Temporal Data' + git config --local user.email 'commander-data@temporal.io' + + - name: Update chart version run: | - echo Doing nothing + RE='\([0-9]*\)\.\([0-9]*\)\.[0-9]*' + + current="$(grep -m 1 '^version:' Chart.yaml | awk '{print $2}')" + + MAJOR=`echo $current | sed -e "s#$RE#\1#"` + MINOR=`echo $current | sed -e "s#$RE#\2#"` + let MINOR+=1 + NEW_VERSION="$MAJOR.$MINOR.0" + + sed -i -e "s/^version: .*/version: $NEW_VERSION/" Chart.yaml + sed -i -e "s/^appVersion: .*/appVersion: ${{ github.event.inputs.version }}/" Chart.yaml + + git commit -m "Update Chart to $NEW_VERSION" Chart.yaml + git push origin + + - name: Create tag + run: | + git tag "$NEW_VERSION" + git push origin "$NEW_VERSION" + + - name: Install Helm + uses: azure/setup-helm@v3 + + - name: Run chart-releaser + uses: helm/chart-releaser-action@v1.6.0 + env: + CR_TOKEN: "${{ secrets.GITHUB_TOKEN }}" diff --git a/Chart.yaml b/charts/temporal/Chart.yaml similarity index 98% rename from Chart.yaml rename to charts/temporal/Chart.yaml index 0a8dc84a..988f2fb7 100644 --- a/Chart.yaml +++ b/charts/temporal/Chart.yaml @@ -49,8 +49,8 @@ type: application # This is the chart version. This version number should be incremented each time you make changes # to the chart and its templates, including the app version. -version: 0.32.0 +version: 0.33.0 # This is the version number of the application being deployed. This version number should be # incremented each time you make changes to the application. -appVersion: 1.22.4 +appVersion: 1.22.9 diff --git a/templates/NOTES.txt b/charts/temporal/templates/NOTES.txt similarity index 100% rename from templates/NOTES.txt rename to charts/temporal/templates/NOTES.txt diff --git a/templates/_helpers.tpl b/charts/temporal/templates/_helpers.tpl similarity index 100% rename from templates/_helpers.tpl rename to charts/temporal/templates/_helpers.tpl diff --git a/templates/admintools-deployment.yaml b/charts/temporal/templates/admintools-deployment.yaml similarity index 100% rename from templates/admintools-deployment.yaml rename to charts/temporal/templates/admintools-deployment.yaml diff --git a/templates/admintools-service.yaml b/charts/temporal/templates/admintools-service.yaml similarity index 100% rename from templates/admintools-service.yaml rename to charts/temporal/templates/admintools-service.yaml diff --git a/templates/server-configmap.yaml b/charts/temporal/templates/server-configmap.yaml similarity index 100% rename from templates/server-configmap.yaml rename to charts/temporal/templates/server-configmap.yaml diff --git a/templates/server-deployment.yaml b/charts/temporal/templates/server-deployment.yaml similarity index 100% rename from templates/server-deployment.yaml rename to charts/temporal/templates/server-deployment.yaml diff --git a/templates/server-dynamicconfigmap.yaml b/charts/temporal/templates/server-dynamicconfigmap.yaml similarity index 100% rename from templates/server-dynamicconfigmap.yaml rename to charts/temporal/templates/server-dynamicconfigmap.yaml diff --git a/templates/server-job.yaml b/charts/temporal/templates/server-job.yaml similarity index 100% rename from templates/server-job.yaml rename to charts/temporal/templates/server-job.yaml diff --git a/templates/server-pdb.yaml b/charts/temporal/templates/server-pdb.yaml similarity index 100% rename from templates/server-pdb.yaml rename to charts/temporal/templates/server-pdb.yaml diff --git a/templates/server-secret.yaml b/charts/temporal/templates/server-secret.yaml similarity index 100% rename from templates/server-secret.yaml rename to charts/temporal/templates/server-secret.yaml diff --git a/templates/server-service-monitor.yaml b/charts/temporal/templates/server-service-monitor.yaml similarity index 100% rename from templates/server-service-monitor.yaml rename to charts/temporal/templates/server-service-monitor.yaml diff --git a/templates/server-service.yaml b/charts/temporal/templates/server-service.yaml similarity index 100% rename from templates/server-service.yaml rename to charts/temporal/templates/server-service.yaml diff --git a/templates/serviceaccount.yaml b/charts/temporal/templates/serviceaccount.yaml similarity index 100% rename from templates/serviceaccount.yaml rename to charts/temporal/templates/serviceaccount.yaml diff --git a/templates/web-configmap.yaml b/charts/temporal/templates/web-configmap.yaml similarity index 100% rename from templates/web-configmap.yaml rename to charts/temporal/templates/web-configmap.yaml diff --git a/templates/web-deployment.yaml b/charts/temporal/templates/web-deployment.yaml similarity index 100% rename from templates/web-deployment.yaml rename to charts/temporal/templates/web-deployment.yaml diff --git a/templates/web-ingress.yaml b/charts/temporal/templates/web-ingress.yaml similarity index 100% rename from templates/web-ingress.yaml rename to charts/temporal/templates/web-ingress.yaml diff --git a/templates/web-service.yaml b/charts/temporal/templates/web-service.yaml similarity index 100% rename from templates/web-service.yaml rename to charts/temporal/templates/web-service.yaml diff --git a/values.yaml b/charts/temporal/values.yaml similarity index 100% rename from values.yaml rename to charts/temporal/values.yaml diff --git a/values/values.antiaffinity.yaml b/charts/temporal/values/values.antiaffinity.yaml similarity index 100% rename from values/values.antiaffinity.yaml rename to charts/temporal/values/values.antiaffinity.yaml diff --git a/values/values.archival.filestore.yaml b/charts/temporal/values/values.archival.filestore.yaml similarity index 100% rename from values/values.archival.filestore.yaml rename to charts/temporal/values/values.archival.filestore.yaml diff --git a/values/values.archival.gcloud.yaml b/charts/temporal/values/values.archival.gcloud.yaml similarity index 100% rename from values/values.archival.gcloud.yaml rename to charts/temporal/values/values.archival.gcloud.yaml diff --git a/values/values.archival.s3.yaml b/charts/temporal/values/values.archival.s3.yaml similarity index 100% rename from values/values.archival.s3.yaml rename to charts/temporal/values/values.archival.s3.yaml diff --git a/values/values.aurora-mysql.yaml b/charts/temporal/values/values.aurora-mysql.yaml similarity index 100% rename from values/values.aurora-mysql.yaml rename to charts/temporal/values/values.aurora-mysql.yaml diff --git a/values/values.cassandra.yaml b/charts/temporal/values/values.cassandra.yaml similarity index 100% rename from values/values.cassandra.yaml rename to charts/temporal/values/values.cassandra.yaml diff --git a/values/values.cloudsqlproxy.yaml b/charts/temporal/values/values.cloudsqlproxy.yaml similarity index 100% rename from values/values.cloudsqlproxy.yaml rename to charts/temporal/values/values.cloudsqlproxy.yaml diff --git a/values/values.dynamic_config.yaml b/charts/temporal/values/values.dynamic_config.yaml similarity index 100% rename from values/values.dynamic_config.yaml rename to charts/temporal/values/values.dynamic_config.yaml diff --git a/values/values.elasticsearch.yaml b/charts/temporal/values/values.elasticsearch.yaml similarity index 100% rename from values/values.elasticsearch.yaml rename to charts/temporal/values/values.elasticsearch.yaml diff --git a/values/values.mysql.yaml b/charts/temporal/values/values.mysql.yaml similarity index 100% rename from values/values.mysql.yaml rename to charts/temporal/values/values.mysql.yaml diff --git a/values/values.ndc.yaml b/charts/temporal/values/values.ndc.yaml similarity index 100% rename from values/values.ndc.yaml rename to charts/temporal/values/values.ndc.yaml diff --git a/values/values.postgresql.yaml b/charts/temporal/values/values.postgresql.yaml similarity index 100% rename from values/values.postgresql.yaml rename to charts/temporal/values/values.postgresql.yaml diff --git a/values/values.prometheus.external.yaml b/charts/temporal/values/values.prometheus.external.yaml similarity index 100% rename from values/values.prometheus.external.yaml rename to charts/temporal/values/values.prometheus.external.yaml diff --git a/values/values.resources.yaml b/charts/temporal/values/values.resources.yaml similarity index 100% rename from values/values.resources.yaml rename to charts/temporal/values/values.resources.yaml From f3a617c583c15af2d3b5ad5cb32e3181f0ea0009 Mon Sep 17 00:00:00 2001 From: Rob Holland Date: Tue, 30 Jan 2024 12:51:42 +0000 Subject: [PATCH 2/8] Fix path. --- .github/workflows/publish-charts.yml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.github/workflows/publish-charts.yml b/.github/workflows/publish-charts.yml index 338adc41..3274f5f1 100644 --- a/.github/workflows/publish-charts.yml +++ b/.github/workflows/publish-charts.yml @@ -34,7 +34,8 @@ jobs: git config --local user.name 'Temporal Data' git config --local user.email 'commander-data@temporal.io' - - name: Update chart version + - name: Update Temporal chart version + working-directory: charts/temporal run: | RE='\([0-9]*\)\.\([0-9]*\)\.[0-9]*' From cea8eeb2ba55980c3e5b1eca39f4d094a300182a Mon Sep 17 00:00:00 2001 From: Rob Holland Date: Tue, 30 Jan 2024 12:53:05 +0000 Subject: [PATCH 3/8] Collapse steps. --- .github/workflows/publish-charts.yml | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/.github/workflows/publish-charts.yml b/.github/workflows/publish-charts.yml index 3274f5f1..7c794bd0 100644 --- a/.github/workflows/publish-charts.yml +++ b/.github/workflows/publish-charts.yml @@ -51,9 +51,7 @@ jobs: git commit -m "Update Chart to $NEW_VERSION" Chart.yaml git push origin - - - name: Create tag - run: | + git tag "$NEW_VERSION" git push origin "$NEW_VERSION" From 194b232302c57b47b193294101a30f4350d8ca3a Mon Sep 17 00:00:00 2001 From: Rob Holland Date: Tue, 30 Jan 2024 15:51:11 +0000 Subject: [PATCH 4/8] Reset version. --- charts/temporal/Chart.yaml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/charts/temporal/Chart.yaml b/charts/temporal/Chart.yaml index 988f2fb7..0a8dc84a 100644 --- a/charts/temporal/Chart.yaml +++ b/charts/temporal/Chart.yaml @@ -49,8 +49,8 @@ type: application # This is the chart version. This version number should be incremented each time you make changes # to the chart and its templates, including the app version. -version: 0.33.0 +version: 0.32.0 # This is the version number of the application being deployed. This version number should be # incremented each time you make changes to the application. -appVersion: 1.22.9 +appVersion: 1.22.4 From c36d23fba7dcaae5909c31595049d6c0bb3d1763 Mon Sep 17 00:00:00 2001 From: Rob Holland Date: Tue, 30 Jan 2024 14:50:39 +0000 Subject: [PATCH 5/8] Allow minor or patch bumps. --- .github/workflows/publish-charts.yml | 23 +++++++++++++++++++---- 1 file changed, 19 insertions(+), 4 deletions(-) diff --git a/.github/workflows/publish-charts.yml b/.github/workflows/publish-charts.yml index 7c794bd0..aa87d28f 100644 --- a/.github/workflows/publish-charts.yml +++ b/.github/workflows/publish-charts.yml @@ -6,6 +6,14 @@ on: version: description: "Temporal version to use for release (for example 1.22.4)" required: true + bump: + description: "Chart version bump level" + required: true + type: choice + default: minor + options: + - minor + - patch jobs: release: @@ -37,19 +45,26 @@ jobs: - name: Update Temporal chart version working-directory: charts/temporal run: | - RE='\([0-9]*\)\.\([0-9]*\)\.[0-9]*' + RE='\([0-9]*\)\.\([0-9]*\)\.\([0-9]*\)' current="$(grep -m 1 '^version:' Chart.yaml | awk '{print $2}')" MAJOR=`echo $current | sed -e "s#$RE#\1#"` MINOR=`echo $current | sed -e "s#$RE#\2#"` - let MINOR+=1 - NEW_VERSION="$MAJOR.$MINOR.0" + PATCH=`echo $current | sed -e "s#$RE#\3#"` + + if [ "${{ github.event.inputs.bump }}" == "minor" ]; then + let MINOR+=1 + let PATCH=0 + else + let PATCH+=1 + fi + NEW_VERSION="$MAJOR.$MINOR.$PATCH" sed -i -e "s/^version: .*/version: $NEW_VERSION/" Chart.yaml sed -i -e "s/^appVersion: .*/appVersion: ${{ github.event.inputs.version }}/" Chart.yaml - git commit -m "Update Chart to $NEW_VERSION" Chart.yaml + git commit -m "Update Chart to $NEW_VERSION, Temporal v${{ github.event.inputs.version }}" Chart.yaml git push origin git tag "$NEW_VERSION" From e0661496ebafd9ee5273b31e2ee2e7b5f5dfd24c Mon Sep 17 00:00:00 2001 From: Rob Holland Date: Tue, 30 Jan 2024 14:52:42 +0000 Subject: [PATCH 6/8] Stop manually adding a tag. Chart releaser already tags before release. --- .github/workflows/publish-charts.yml | 3 --- 1 file changed, 3 deletions(-) diff --git a/.github/workflows/publish-charts.yml b/.github/workflows/publish-charts.yml index aa87d28f..c98e5530 100644 --- a/.github/workflows/publish-charts.yml +++ b/.github/workflows/publish-charts.yml @@ -66,9 +66,6 @@ jobs: git commit -m "Update Chart to $NEW_VERSION, Temporal v${{ github.event.inputs.version }}" Chart.yaml git push origin - - git tag "$NEW_VERSION" - git push origin "$NEW_VERSION" - name: Install Helm uses: azure/setup-helm@v3 From 3e9c6e36e3da78cb2b2cea6714d11a2ddb09904b Mon Sep 17 00:00:00 2001 From: Rob Holland Date: Tue, 30 Jan 2024 15:29:08 +0000 Subject: [PATCH 7/8] Update README. Further work needed to give good instructions for using the repo version. --- README.md | 31 ++++++++++++++++--------------- 1 file changed, 16 insertions(+), 15 deletions(-) diff --git a/README.md b/README.md index 97d798c2..2c1229ae 100644 --- a/README.md +++ b/README.md @@ -16,17 +16,18 @@ This Helm Chart code is tested by a dedicated test pipeline. It is also used ext This sequence assumes * that your system is configured to access a kubernetes cluster (e. g. [AWS EKS](https://aws.amazon.com/eks/), [kind](https://kind.sigs.k8s.io/), or [minikube](https://kubernetes.io/docs/tasks/tools/install-minikube/)), and * that your machine has - - [AWS CLI V2](https://docs.aws.amazon.com/cli/latest/userguide/install-cliv2.html), - [kubectl](https://kubernetes.io/docs/tasks/tools/install-kubectl/), and - [Helm v3](https://helm.sh) installed and able to access your cluster. +This repo only contains one chart currently, but is structured in the standard helm repo way. This means you will find the chart in the `charts/temporal` directory. All example `helm` commands below should be run from that directory. + ## Download Helm Chart Dependencies Download Helm dependencies: ```bash -~/temporal-helm$ helm dependencies update +helm dependencies update ``` ## Install Temporal with Helm Chart @@ -44,8 +45,8 @@ The sections that follow describe various deployment configurations, from a mini To install Temporal in a limited but working and self-contained configuration (one replica of Cassandra and each of Temporal's services, no metrics or ElasticSearch), you can run the following command -``` -~/temporal-helm$ helm install \ +```bash +helm install \ --set server.replicaCount=1 \ --set cassandra.config.cluster_size=1 \ --set prometheus.enabled=false \ @@ -80,7 +81,7 @@ By default, Temporal Helm Chart configures Temporal to run with a three node Cas To install Temporal with all of its dependencies run this command: ```bash -~/temporal-helm$ helm install temporaltest . --timeout 900s +helm install temporaltest . --timeout 900s ``` To use your own instance of ElasticSearch, MySQL, PostgreSQL, or Cassandra, please read the "Bring Your Own" sections below. @@ -88,7 +89,7 @@ To use your own instance of ElasticSearch, MySQL, PostgreSQL, or Cassandra, plea Other components (Prometheus, Grafana) can be omitted from the installation by setting their corresponding `enable` flag to `false`: ```bash -~/temporal-helm$ helm install \ +helm install \ --set prometheus.enabled=false \ --set grafana.enabled=false \ temporaltest . --timeout 900s @@ -103,7 +104,7 @@ To do so, you may look at the example for Google's `cloud sql proxy` in the `val Example: ```bash -~/temporal-helm$ helm install -f values/values.cloudsqlproxy.yaml temporaltest . --timeout 900s +helm install -f values/values.cloudsqlproxy.yaml temporaltest . --timeout 900s ``` ### Install with your own ElasticSearch @@ -115,7 +116,7 @@ To do so, fill in the relevant configuration values in `values.elasticsearch.yam Example: ```bash -~/temporal-helm$ helm install -f values/values.elasticsearch.yaml temporaltest . --timeout 900s +helm install -f values/values.elasticsearch.yaml temporaltest . --timeout 900s ``` ### Install with your own MySQL @@ -243,7 +244,7 @@ CASSANDRA_KEYSPACE=temporal_visibility ./temporal-cassandra-tool update -schema- Once you initialized the two keyspaces, fill in the configuration values in `values/values.cassandra.yaml`, and run ```bash -~/temporal-helm$ helm install -f values/values.cassandra.yaml temporaltest . --timeout 900s +helm install -f values/values.cassandra.yaml temporaltest . --timeout 900s ``` ### Enable Archival @@ -454,11 +455,11 @@ By default dynamic config is empty, if you want to override some properties for 2. Populate it with some values under server.dynamicConfig prefix (use the sample provided at `values/values.dynamic_config.yaml` as a starting point) 3. Install your helm configuration: ```bash -$ helm install -f values/values.dynamic_config.yaml temporaltest . --timeout 900s +helm install -f values/values.dynamic_config.yaml temporaltest . --timeout 900s ``` Note that if you already have a running cluster you can use the "helm upgrade" command to change dynamic config values: ```bash -$ helm upgrade -f values/values.dynamic_config.yaml temporaltest . --timeout 900s +helm upgrade -f values/values.dynamic_config.yaml temporaltest . --timeout 900s ``` WARNING: The "helm upgrade" approach will trigger a rolling upgrade of all the pods. @@ -466,7 +467,7 @@ WARNING: The "helm upgrade" approach will trigger a rolling upgrade of all the p If a rolling upgrade is not desirable, you can also generate the ConfigMap file explicitly and then apply it using the following command: ```bash -$ kubectl apply -f dynamicconfigmap.yaml +kubectl apply -f dynamicconfigmap.yaml ``` You can use helm upgrade with the "--dry-run" option to generate the content for the dynamicconfigmap.yaml. @@ -480,7 +481,7 @@ the config file `server/config.yml` for the temporal web ui is referenced as a m Note: in this example chart, uninstalling a Temporal instance also removes all the data that might have been created during its lifetime. ```bash -~/temporal-helm $ helm uninstall temporaltest +helm uninstall temporaltest ``` ## Upgrading @@ -533,8 +534,8 @@ To upgrade your MySQL database, please use `temporal-sql-tool` tool instead of ` Here is an example of a `helm upgrade` command that can be used to upgrade a cluster: -``` -helm-charts $ helm \ +```bash +helm \ upgrade \ temporaltest \ -f values/values.cassandra.yaml \ From a97d50026081d125c9a90bcc824d379aee2be713 Mon Sep 17 00:00:00 2001 From: Rob Holland Date: Tue, 30 Jan 2024 16:50:51 +0000 Subject: [PATCH 8/8] Easier to read RE. --- .github/workflows/publish-charts.yml | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/.github/workflows/publish-charts.yml b/.github/workflows/publish-charts.yml index c98e5530..bb747bcf 100644 --- a/.github/workflows/publish-charts.yml +++ b/.github/workflows/publish-charts.yml @@ -45,13 +45,13 @@ jobs: - name: Update Temporal chart version working-directory: charts/temporal run: | - RE='\([0-9]*\)\.\([0-9]*\)\.\([0-9]*\)' + RE='([0-9]+)\.([0-9]+)\.([0-9]+)' current="$(grep -m 1 '^version:' Chart.yaml | awk '{print $2}')" - MAJOR=`echo $current | sed -e "s#$RE#\1#"` - MINOR=`echo $current | sed -e "s#$RE#\2#"` - PATCH=`echo $current | sed -e "s#$RE#\3#"` + MAJOR=`echo $current | sed -E "s#$RE#\1#"` + MINOR=`echo $current | sed -E "s#$RE#\2#"` + PATCH=`echo $current | sed -E "s#$RE#\3#"` if [ "${{ github.event.inputs.bump }}" == "minor" ]; then let MINOR+=1