Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] reqrespactivity/reqrespquery samples have wrong assumpion about Selector.HasPending #312

Open
cretz opened this issue Oct 26, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@cretz
Copy link
Member

cretz commented Oct 26, 2023

Describe the bug

When I originally developed the reqrespactivity/reqrespquery code, I had a misunderstanding about HasPending() in that I improperly assumed it would return true while a future is outstanding which is not the case, it only returns true if the future is completed and just not handled.

The samples need to be updated to not exit their loop while selector.HasPending or there are unresolved futures.

@cretz cretz added the bug Something isn't working label Oct 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant