Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature Request] Change namespace metric label to be less ambiguous, preventing conflicts #632

Open
wise0wl opened this issue Nov 15, 2023 · 1 comment
Open

[Feature Request] Change namespace metric label to be less ambiguous, preventing conflicts #632

wise0wl opened this issue Nov 15, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@wise0wl
Copy link

wise0wl commented Nov 15, 2023

Is your feature request related to a problem? Please describe.

Currently all metrics have a label namespace attached. However this label namespace is the prometheus default label rename for the default __meta_kubernetes_namespace label. This causes conflicts and subsequent issues when in Kubernetes environments monitored by Prometheus.

Describe the solution you'd like

Allow this label to be either set to something like temporal_namespace by default, and / or make it configurable.
@wise0wl wise0wl added the enhancement New feature or request label Nov 15, 2023
@cretz
Copy link
Member

cretz commented Nov 15, 2023

While we can't change what's there, I don't see why we couldn't have a metric_attribute_prefix that can be set. Will defer to @Sushisource.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cretz @wise0wl