Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle multiple completion commands #305

Open
dandavison opened this issue Jul 13, 2024 · 1 comment
Open

Handle multiple completion commands #305

dandavison opened this issue Jul 13, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@dandavison
Copy link
Contributor

The change made in #270 is incorrect when there are multiple completion commands: in that case, we may still leave non-query commands after a completion command, and currently core removes any such commands.

We are going to fix this in core (temporalio/sdk-core#778). This ticket is blocked on the core work but we anticipate the fix here to be straightforward: send all commands to core i.e. with (potentially multiple) completion commands interleaved with non-completions.

@cretz
Copy link
Member

cretz commented Jul 15, 2024

👍 Note as part of this work we still have to leave existing logic, but only if this flag is present. I am unsure how safe we feel about removing the old .NET logic of truncating post-completion commands (since Core was doing it too), up for discussion. It would be nice if the .NET command reordering we did here was only if this flag was set and we could leave everything else (including truncation) up to Core.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants