Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle all exceptions as non-retryable when TEMPORAL_DEBUG is set #499

Open
mobiletoly opened this issue May 18, 2021 · 1 comment
Open
Labels
enhancement User experience

Comments

@mobiletoly
Copy link

Is your feature request related to a problem? Please describe.
By default all exceptions are Retryable in workflows/activities and it makes troubleshooting much harder when we have to deal with a core exceptions such as NullPointerException, InvalidArgumentException, SQL errors etc during a development cycle.

Describe the solution you'd like
TEMPORAL_DEBUG env variable is already in use to assist with debugging (e.g. timeouts) and it could be reused to handle all exception as non-retryable by default.

There is some discussion here as well that might provide more context:
https://temporalio.slack.com/archives/CTT84KXK9/p1621341005008500

@mobiletoly mobiletoly added the enhancement User experience label May 18, 2021
@vitarb
Copy link
Contributor

vitarb commented May 24, 2021

Hey @mobiletoly, TEMPORAL_DEBUG is intended to be used to adjust certain timeouts so that when you stop in the debugger you don't affect workflow execution. Your proposal goes slightly against this idea as it would alter workflow behavior by changing how it handles the errors. I don't like this, as it could make certain tests pass/fail with or without the flag.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement User experience
Projects
None yet
Development

No branches or pull requests

2 participants