From 31cc90e7e47181eff398eea6b7a83e6f1f9e68ae Mon Sep 17 00:00:00 2001 From: roxblnfk Date: Mon, 10 Jul 2023 16:11:03 +0400 Subject: [PATCH] Comment tests that break CI with PHP <8.2 --- .../src/Activity/Php82TypesActivity.php | 5 +++-- tests/Functional/Client/TypedStubTestCase.php | 21 ++++++++++--------- 2 files changed, 14 insertions(+), 12 deletions(-) diff --git a/tests/Fixtures/src/Activity/Php82TypesActivity.php b/tests/Fixtures/src/Activity/Php82TypesActivity.php index 87605727..035bc12e 100644 --- a/tests/Fixtures/src/Activity/Php82TypesActivity.php +++ b/tests/Fixtures/src/Activity/Php82TypesActivity.php @@ -13,7 +13,8 @@ use Temporal\Activity\ActivityInterface; use Temporal\Activity\ActivityMethod; - +/* +todo: uncomment this with min php 8.2 requirement or when we can skip activities loading depending on php version #[ActivityInterface(prefix: "Php82.")] class Php82TypesActivity { @@ -34,4 +35,4 @@ public function returnFalse(false $value): false { return $value; } -} +}*/ diff --git a/tests/Functional/Client/TypedStubTestCase.php b/tests/Functional/Client/TypedStubTestCase.php index 7e44e7af..f3ffda95 100644 --- a/tests/Functional/Client/TypedStubTestCase.php +++ b/tests/Functional/Client/TypedStubTestCase.php @@ -163,15 +163,16 @@ public function testSignalRunningWorkflowWithInheritedSignalViaParentInterface() /** * @requires PHP >= 8.2 + * todo: uncomment this with min php 8.2 requirement or when we can skip activities loading depending on php version */ - public function testPhp82Types(): void - { - $client = $this->createClient(); - - $workflow = $client->newWorkflowStub(Php82TypesWorkflow::class); - $workflowRun = $client->start($workflow); - $result = $workflowRun->getResult(); - - $this->assertSame([null, true, false], $result); - } + // public function testPhp82Types(): void + // { + // $client = $this->createClient(); + // + // $workflow = $client->newWorkflowStub(Php82TypesWorkflow::class); + // $workflowRun = $client->start($workflow); + // $result = $workflowRun->getResult(); + // + // $this->assertSame([null, true, false], $result); + // } }