Rename WorkflowInboundInterceptor to `WorkflowInboundCallsIntercept…

…or` (#371)

src/Interceptor/Trait/WorkflowInboundInterceptorTrait.php → src/Interceptor/Trait/WorkflowInboundCallsInterceptorTrait.php

@@ -14,31 +14,31 @@
 use Temporal\Interceptor\WorkflowInbound\QueryInput;
 use Temporal\Interceptor\WorkflowInbound\SignalInput;
 use Temporal\Interceptor\WorkflowInbound\WorkflowInput;
-use Temporal\Interceptor\WorkflowInboundInterceptor;
+use Temporal\Interceptor\WorkflowInboundCallsInterceptor;
 
 /**
- * Implements {@see WorkflowInboundInterceptor}
+ * Implements {@see WorkflowInboundCallsInterceptor}
  */
-trait WorkflowInboundInterceptorTrait
+trait WorkflowInboundCallsInterceptorTrait
 {
     /**
-     * @see WorkflowInboundInterceptor::execute()
+     * @see WorkflowInboundCallsInterceptor::execute()
      */
     public function execute(WorkflowInput $input, callable $next): void
     {
         $next($input);
     }
 
     /**
-     * @see WorkflowInboundInterceptor::handleSignal()
+     * @see WorkflowInboundCallsInterceptor::handleSignal()
      */
     public function handleSignal(SignalInput $input, callable $next): void
     {
         $next($input);
     }
 
     /**
-     * @see WorkflowInboundInterceptor::handleQuery()
+     * @see WorkflowInboundCallsInterceptor::handleQuery()
      */
     public function handleQuery(QueryInput $input, callable $next): mixed
     {

src/Interceptor/WorkflowInboundInterceptor.php → src/Interceptor/WorkflowInboundCallsInterceptor.php

@@ -11,19 +11,19 @@
 
 namespace Temporal\Interceptor;
 
-use Temporal\Interceptor\Trait\WorkflowInboundInterceptorTrait;
+use Temporal\Interceptor\Trait\WorkflowInboundCallsInterceptorTrait;
 use Temporal\Interceptor\WorkflowInbound\QueryInput;
 use Temporal\Interceptor\WorkflowInbound\SignalInput;
 use Temporal\Interceptor\WorkflowInbound\WorkflowInput;
 use Temporal\Internal\Interceptor\Interceptor;
 
 /**
- * It's recommended to use {@see WorkflowInboundInterceptorTrait} when implementing this interface because
+ * It's recommended to use {@see WorkflowInboundCallsInterceptorTrait} when implementing this interface because
  * the interface might be extended in the future. The trait will provide forward compatibility.
  *
  * @psalm-immutable
  */
-interface WorkflowInboundInterceptor extends Interceptor
+interface WorkflowInboundCallsInterceptor extends Interceptor
 {
     /**
      * @param WorkflowInput $input

src/Internal/Declaration/Instantiator/WorkflowInstantiator.php

@@ -12,7 +12,7 @@
 namespace Temporal\Internal\Declaration\Instantiator;
 
 use Temporal\Exception\InstantiationException;
-use Temporal\Interceptor\WorkflowInboundInterceptor;
+use Temporal\Interceptor\WorkflowInboundCallsInterceptor;
 use Temporal\Internal\Declaration\Prototype\PrototypeInterface;
 use Temporal\Internal\Declaration\Prototype\WorkflowPrototype;
 use Temporal\Internal\Declaration\WorkflowInstance;
@@ -37,7 +37,7 @@ public function instantiate(PrototypeInterface $prototype): WorkflowInstance
         return new WorkflowInstance(
             $prototype,
             $this->getInstance($prototype),
-            $this->interceptorProvider->getPipeline(WorkflowInboundInterceptor::class),
+            $this->interceptorProvider->getPipeline(WorkflowInboundCallsInterceptor::class),
         );
     }
 

src/Internal/Declaration/WorkflowInstance.php

@@ -13,7 +13,7 @@
 
 use Temporal\DataConverter\ValuesInterface;
 use Temporal\Interceptor\WorkflowInbound\QueryInput;
-use Temporal\Interceptor\WorkflowInboundInterceptor;
+use Temporal\Interceptor\WorkflowInboundCallsInterceptor;
 use Temporal\Internal\Declaration\Prototype\WorkflowPrototype;
 use Temporal\Internal\Declaration\WorkflowInstance\SignalQueue;
 use Temporal\Internal\Interceptor;
@@ -46,7 +46,7 @@ final class WorkflowInstance extends Instance implements WorkflowInstanceInterfa
     /**
      * @param WorkflowPrototype $prototype
      * @param object $context
-     * @param Interceptor\Pipeline<WorkflowInboundInterceptor, mixed> $pipeline
+     * @param Interceptor\Pipeline<WorkflowInboundCallsInterceptor, mixed> $pipeline
      */
     public function __construct(
         WorkflowPrototype $prototype,
@@ -68,7 +68,7 @@ public function __construct(
                 function (QueryInput $input) use ($fn) {
                     return ($this->queryExecutor)($input, $fn);
                 },
-                /** @see WorkflowInboundInterceptor::handleQuery() */
+                /** @see WorkflowInboundCallsInterceptor::handleQuery() */
                 'handleQuery',
             ));
         }
@@ -127,7 +127,7 @@ public function addQueryHandler(string $name, callable $handler): void
             function (QueryInput $input) use ($fn) {
                 return ($this->queryExecutor)($input, $fn);
             },
-            /** @see WorkflowInboundInterceptor::handleQuery() */
+            /** @see WorkflowInboundCallsInterceptor::handleQuery() */
             'handleQuery',
         ));
     }

src/Internal/Transport/Router/StartWorkflow.php

@@ -14,7 +14,7 @@
 use React\Promise\Deferred;
 use Temporal\DataConverter\EncodedValues;
 use Temporal\Interceptor\WorkflowInbound\WorkflowInput;
-use Temporal\Interceptor\WorkflowInboundInterceptor;
+use Temporal\Interceptor\WorkflowInboundCallsInterceptor;
 use Temporal\Internal\Declaration\Instantiator\WorkflowInstantiator;
 use Temporal\Internal\Declaration\Prototype\WorkflowPrototype;
 use Temporal\Internal\ServiceContainer;
@@ -96,10 +96,10 @@ public function handle(ServerRequestInterface $request, array $headers, Deferred
 
         // Run workflow handler in an interceptor pipeline
         $this->services->interceptorProvider
-            ->getPipeline(WorkflowInboundInterceptor::class)
+            ->getPipeline(WorkflowInboundCallsInterceptor::class)
             ->with(
                 $starter,
-                /** @see WorkflowInboundInterceptor::execute() */
+                /** @see WorkflowInboundCallsInterceptor::execute() */
                 'execute',
             )(
                 new WorkflowInput($context->getInfo(), $context->getInput(), $context->getHeader()),

src/Internal/Workflow/Process/Process.php

@@ -16,7 +16,7 @@
 use Temporal\Exception\DestructMemorizedInstanceException;
 use Temporal\Interceptor\WorkflowInbound\QueryInput;
 use Temporal\Interceptor\WorkflowInbound\SignalInput;
-use Temporal\Interceptor\WorkflowInboundInterceptor;
+use Temporal\Interceptor\WorkflowInboundCallsInterceptor;
 use Temporal\Internal\Declaration\WorkflowInstance;
 use Temporal\Internal\Declaration\WorkflowInstanceInterface;
 use Temporal\Internal\ServiceContainer;
@@ -45,7 +45,7 @@ public function __construct(
     ) {
         parent::__construct($services, $ctx);
 
-        $inboundPipeline = $services->interceptorProvider->getPipeline(WorkflowInboundInterceptor::class);
+        $inboundPipeline = $services->interceptorProvider->getPipeline(WorkflowInboundCallsInterceptor::class);
         $wfInstance = $this->getWorkflowInstance();
         \assert($wfInstance instanceof WorkflowInstance);
 
@@ -92,7 +92,7 @@ function (?\Throwable $error): void {
                             $input->arguments
                         );
                     },
-                    /** @see WorkflowInboundInterceptor::handleSignal() */
+                    /** @see WorkflowInboundCallsInterceptor::handleSignal() */
                     'handleSignal',
                 )(new SignalInput(
                     $name,

src/Internal/Workflow/WorkflowContext.php

@@ -359,7 +359,7 @@ public function executeChildWorkflow(
         string $type,
         array $args = [],
         ChildWorkflowOptions $options = null,
-        $returnType = null,
+        mixed $returnType = null,
     ): PromiseInterface {
         return $this->callsInterceptor->with(
             fn(ExecuteChildWorkflowInput $input): PromiseInterface => $this
@@ -467,7 +467,7 @@ public function newUntypedActivityStub(
     public function newActivityStub(
         string $class,
         ActivityOptionsInterface $options = null,
-    ): object {
+    ): ActivityProxy {
         $activities = $this->services->activitiesReader->fromClass($class);
 
         if (isset($activities[0]) && $activities[0]->isLocalActivity() && !$options instanceof LocalActivityOptions) {

src/Workflow.php

@@ -580,7 +580,7 @@ public static function executeChildWorkflow(
         string $type,
         array $args = [],
         ChildWorkflowOptions $options = null,
-        $returnType = null,
+        mixed $returnType = null,
     ): PromiseInterface {
         return self::getCurrentContext()->executeChildWorkflow($type, $args, $options, $returnType);
     }

tests/Fixtures/PipelineProvider.php

@@ -13,7 +13,7 @@
 
 use Temporal\Interceptor\ActivityInboundInterceptor;
 use Temporal\Interceptor\WorkflowClientCallsInterceptor;
-use Temporal\Interceptor\WorkflowInboundInterceptor;
+use Temporal\Interceptor\WorkflowInboundCallsInterceptor;
 use Temporal\Interceptor\WorkflowOutboundRequestInterceptor;
 use Temporal\Internal\Interceptor\Interceptor;
 use Temporal\Internal\Interceptor\Pipeline;
@@ -26,7 +26,7 @@ final class PipelineProvider implements \Temporal\Interceptor\PipelineProvider
      * @param array<class-string<Type>, array<class-string<Type>>> $classes
      */
     private array $classes = [
-        WorkflowInboundInterceptor::class => [],
+        WorkflowInboundCallsInterceptor::class => [],
         WorkflowOutboundRequestInterceptor::class => [],
         ActivityInboundInterceptor::class => [],
         WorkflowClientCallsInterceptor::class => [],

tests/Fixtures/src/Interceptor/HeaderChanger.php

@@ -15,11 +15,11 @@
 use RuntimeException;
 use Temporal\Interceptor\Header;
 use Temporal\Interceptor\Trait\WorkflowClientCallsInterceptorTrait;
-use Temporal\Interceptor\Trait\WorkflowInboundInterceptorTrait;
+use Temporal\Interceptor\Trait\WorkflowInboundCallsInterceptorTrait;
 use Temporal\Interceptor\WorkflowClient\StartInput;
 use Temporal\Interceptor\WorkflowClientCallsInterceptor;
 use Temporal\Interceptor\WorkflowInbound\WorkflowInput;
-use Temporal\Interceptor\WorkflowInboundInterceptor;
+use Temporal\Interceptor\WorkflowInboundCallsInterceptor;
 use Temporal\Interceptor\WorkflowOutboundRequestInterceptor;
 use Temporal\Internal\Transport\Request\ExecuteActivity;
 use Temporal\Tests\Workflow\Header\ChildedHeaderWorkflow;
@@ -35,10 +35,10 @@
  */
 final class HeaderChanger implements
     WorkflowOutboundRequestInterceptor,
-    WorkflowInboundInterceptor,
+    WorkflowInboundCallsInterceptor,
     WorkflowClientCallsInterceptor
 {
-    use WorkflowInboundInterceptorTrait;
+    use WorkflowInboundCallsInterceptorTrait;
     use WorkflowClientCallsInterceptorTrait;
 
     private function processInput(StartInput $input): StartInput

tests/Fixtures/src/Interceptor/InterceptorCallsCounter.php

@@ -25,7 +25,7 @@
 use Temporal\Interceptor\WorkflowInbound\QueryInput;
 use Temporal\Interceptor\WorkflowInbound\SignalInput;
 use Temporal\Interceptor\WorkflowInbound\WorkflowInput;
-use Temporal\Interceptor\WorkflowInboundInterceptor;
+use Temporal\Interceptor\WorkflowInboundCallsInterceptor;
 use Temporal\Interceptor\WorkflowOutboundRequestInterceptor;
 use Temporal\Worker\Transport\Command\RequestInterface;
 use Temporal\Workflow;
@@ -41,7 +41,7 @@
 final class InterceptorCallsCounter implements
     WorkflowOutboundRequestInterceptor,
     ActivityInboundInterceptor,
-    WorkflowInboundInterceptor,
+    WorkflowInboundCallsInterceptor,
     WorkflowClientCallsInterceptor
 {
     private function increment(HeaderInterface $header, string $key): HeaderInterface