[Not a Bug] await doesn't interrupts on the activity with error

[pfy-oleksii-storozhylov]

What are you really trying to do?

I want to use await function to ensure that activities are completed with or without an errors

Describe the bug

When any activity is completed with error, await function doesn't continue workflow immediately, it waits for the full interval

Minimal Reproduction

            foreach ($anticipationPromises as $promise) {
                $promise
                    ->then(function() use (&$index) {
                        $index++;
                        file_put_contents('/srv/app/ddd.log', time()." success $index\n", FILE_APPEND);
                    })
                    ->otherwise(function() use (&$index) {
                        $index++;
                        file_put_contents('/srv/app/ddd.log', time()." error $index\n", FILE_APPEND);
                    });
            }

            file_put_contents('/srv/app/ddd.log', time(). " start awaiting $index\n", FILE_APPEND);

            yield \Temporal\Workflow::awaitWithTimeout(
                 CarbonInterval::seconds(60),
                \React\Promise\all($anticipationPromises)
             );

            file_put_contents('/srv/app/ddd.log', time(). " complete $index\n", FILE_APPEND);

Result when 2 activities have no errors looks good

1708030014 start awaiting 0
1708030016 success 1
1708030018 success 2
1708030018 complete 2

Result when one of the activities has an error looks good (completion takes 60 seconds)

1708030094 start awaiting 0
1708030096 error 1
1708030098 success 2
1708030154 complete 2

Environment/Versions

• temporal/sdk 2.7+

Additional context

[pfy-oleksii-storozhylov]

workarround with a counter and deferred promise could be used

$index = 0;

            $deferred = new Deferred();
            $deferred->promise()
                ->then(function () use (&$index) {
                    file_put_contents('/srv/app/ddd.log', time() . " deferred resolved $index\n", FILE_APPEND);
                });

            foreach ($anticipationPromises as $promise) {
                $promise
                    ->then(function () use (&$index, $deferred) {
                        $index++;
                        file_put_contents('/srv/app/ddd.log', time() . " success $index\n", FILE_APPEND);

                        if ($index >= 2) {
                            $deferred->resolve(true);
                        }
                    })
                    ->otherwise(function () use (&$index, $deferred) {
                        $index++;
                        file_put_contents('/srv/app/ddd.log', time() . " error $index\n", FILE_APPEND);

                        if ($index >= 2) {
                            $deferred->resolve(true);
                        }
                    });
            }

            file_put_contents('/srv/app/ddd.log', time() . " start awaiting $index\n", FILE_APPEND);

            yield \Temporal\Workflow::awaitWithTimeout(
                CarbonInterval::seconds(60),
                $deferred->promise()
            );

And the result looks good

1708030906 start awaiting 0
1708030908 error 1
1708030910 success 2
1708030910 deferred resolved 2
1708030910 complete 2

[pfy-oleksii-storozhylov]

Seems not an issue, all promise is rejected if any of promises is rejected, so the solution here is

            yield \Temporal\Workflow::awaitWithTimeout(
                CarbonInterval::seconds(60),
                \Temporal\Promise::all(array_map(
                    fn (ExtendedPromiseInterface $promise) => $promise->otherwise(fn () => false),
                    $promises
                ))
            );

[wolfy-j]

I would like to keep this issue open for our records, so we can check the await behavior in combination with promise chaining.