From 5050a1a5a522eb5a6120980f0ed3d5fd6ca1801a Mon Sep 17 00:00:00 2001 From: Dan Davison Date: Wed, 18 Dec 2024 16:59:21 -0500 Subject: [PATCH] Clean up --- temporalio/client.py | 1 - tests/worker/test_update_with_start.py | 28 -------------------------- 2 files changed, 29 deletions(-) diff --git a/temporalio/client.py b/temporalio/client.py index 0ce22a95..0ec15a98 100644 --- a/temporalio/client.py +++ b/temporalio/client.py @@ -5985,7 +5985,6 @@ async def start_workflow_update( client=self._client, id=req.request.meta.update_id, workflow_id=workflow_id, - # TODO: Why don't we use the run ID from the update response here? workflow_run_id=input.run_id, result_type=input.ret_type, ) diff --git a/tests/worker/test_update_with_start.py b/tests/worker/test_update_with_start.py index c2d2383f..b92833f6 100644 --- a/tests/worker/test_update_with_start.py +++ b/tests/worker/test_update_with_start.py @@ -415,34 +415,6 @@ def make_start_op(workflow_id: str): await aw -async def test_workflow_update_poll_loop(client: Client): - # TODO: mock server to test retry loop - pytest.skip( - "It's too slow to actually do this in the test suite: retries occur every 20s" - ) - start_op = WithStartWorkflowOperation( - NeverExecutedWorkflow.run, - id=f"wf-{uuid.uuid4()}", - task_queue="does-not-exist", - id_conflict_policy=WorkflowIDConflictPolicy.FAIL, - ) - with patch.object( - client.workflow_service, - "execute_multi_operation", - wraps=client.workflow_service.execute_multi_operation, - ) as workflow_service_method: - try: - await client.execute_update_with_start_workflow( - NeverExecutedWorkflow.do_update, - start_workflow_operation=start_op, - ) - except: - print( - f"execute_multi_operation was called {workflow_service_method.call_count} times" - ) - raise - - class SimpleClientInterceptor(Interceptor): def intercept_client(self, next: OutboundInterceptor) -> OutboundInterceptor: return SimpleClientOutboundInterceptor(super().intercept_client(next))