Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Client may not be reconnecting on server shutdown/restart #397

Closed
cretz opened this issue Oct 9, 2023 · 1 comment
Closed

[Bug] Client may not be reconnecting on server shutdown/restart #397

cretz opened this issue Oct 9, 2023 · 1 comment
Labels
bug Something isn't working

Comments

@cretz
Copy link
Member

cretz commented Oct 9, 2023

Describe the bug

There are reports of clients not auto-reconnecting on server shutdown/restart. Confirm that clients for direct use and for worker use are properly auto-reconnecting. This may be solved by #396, but confirm.

@cretz cretz added the bug Something isn't working label Oct 9, 2023
@cretz
Copy link
Member Author

cretz commented Dec 7, 2023

I have done the following test:

  • Start a server
  • Start a worker
  • Start another process that creates a single client at the beginning and runs a workflow every second
  • Stop the server
    • This will get core warnings on worker like "WARN temporal_client::retry: gRPC call poll_workflow_task_queue retried 6 times" but will not fail the worker
    • This will get core warnings on the client like "WARN temporal_client::retry: gRPC call start_workflow_execution retried 7 time" and after some retries it will raise an exception to the caller (which we trap for this test)
  • Start the server
    • The worker automatically recovers
    • The same exact client instance is usable again for starting workflows

I do not believe this is an issue unless I can get more details on how to replicate

@cretz cretz closed this as not planned Won't fix, can't repro, duplicate, stale Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant