Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Issue when failing to build activity failure #685

Open
cretz opened this issue Nov 6, 2024 · 0 comments
Open

[Bug] Issue when failing to build activity failure #685

cretz opened this issue Nov 6, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@cretz
Copy link
Member

cretz commented Nov 6, 2024

Describe the bug

When activity fails, but the failure can't be converted for whatever reason, we build a general failure at

completion.result.Clear()
completion.result.failed.failure.message = (
f"Failed building exception result: {inner_err}"
)
. But we aren't properly building this by putting application failure info in it. We fixed the same issue in .NET recently: temporalio/sdk-dotnet#353. We need to do the same here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant