From 190f2bbb6f401306776521cc1caf45b5377c8a24 Mon Sep 17 00:00:00 2001
From: James Watkins-Harvey <james.watkinsharvey@temporal.io>
Date: Fri, 29 Nov 2024 22:15:17 -0500
Subject: [PATCH] Debugging somes bugs

---
 .github/workflows/ci.yml | 18 ++++++++++++++----
 1 file changed, 14 insertions(+), 4 deletions(-)

diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
index c6c6cafa3..a666a8cdf 100644
--- a/.github/workflows/ci.yml
+++ b/.github/workflows/ci.yml
@@ -141,9 +141,7 @@ jobs:
       run:
         shell: bash
     steps:
-      - id: tmp-dir
-        run: echo "dir=$(pwd)" >> ${GITHUB_OUTPUT}
-        working-directory: ${{ runner.temp }}
+      - run: git config --global core.autocrlf true
 
       - name: 'Checkout code'
         uses: actions/checkout@v4
@@ -161,6 +159,18 @@ jobs:
         with:
           node-version: ${{ matrix.node }}
 
+      # On Windows, the 'runner.temp' variable uses backslashes as path separators, but
+      # that may pose problems in later steps when we try to join that with subpaths;
+      # e.g. '${{ runner.temp }}/npm-registry' would get interpolated to 'd:\a\_temp/npm-registry',
+      # which may effectively get interpreted as by bash as 'd:a_temp/npm-registry', resulting in
+      # the apparition of an unwanted 'a_temp' directory.
+      #
+      # This step ensures that the 'runner.temp' variable is normalized to use forward slashes.
+      - name: Get normalized path to temp directory
+        id: tmp-dir
+        run: echo "dir=$(pwd)" >> ${GITHUB_OUTPUT}
+        working-directory: ${{ runner.temp }}
+
       - name: Get NPM cache directory
         id: npm-cache-dir
         run: echo "dir=$(npm config get cache)" >> ${GITHUB_OUTPUT}
@@ -263,7 +273,7 @@ jobs:
         if: failure() || cancelled()
         with:
           name: integration-tests-${{ matrix.platform }}-node${{ matrix.node }}-${{ matrix.reuse-v8-context && 'reuse' || 'noreuse' }}-devserver-logs
-          path: ${{ runner.temp }}/devserver.log
+          path: ${{ steps.tmp-dir.outputs.dir }}/devserver.log
 
   conventions:
     name: Lint and Prune