From 4d0a1d46faff1d928c6627a06d251fc4f9b0019e Mon Sep 17 00:00:00 2001 From: Matt Hurd Date: Thu, 12 Dec 2024 11:58:05 -0800 Subject: [PATCH] Internal change PiperOrigin-RevId: 705582910 --- defs/{BUILD.bazel => BUILD} | 0 frontend/app/BUILD | 1 + frontend/app/components/capture_profile/BUILD | 1 + .../capture_profile/capture_profile_dialog/BUILD | 1 + .../app/components/chart/default_data_provider.ts | 4 ++-- frontend/app/components/chart/org_chart/BUILD | 1 + frontend/app/components/chart/table/BUILD | 1 + .../app/components/controls/category_filter/BUILD | 1 + frontend/app/components/controls/export_as_csv/BUILD | 1 + frontend/app/components/controls/string_filter/BUILD | 2 ++ frontend/app/components/dcn_collective_stats/BUILD | 2 ++ frontend/app/components/diagnostics_view/BUILD | 1 + frontend/app/components/empty_page/BUILD | 1 + frontend/app/components/framework_op_stats/BUILD | 2 ++ .../framework_op_stats/flop_rate_chart/BUILD | 2 ++ .../framework_op_stats/model_properties/BUILD | 1 + .../framework_op_stats/operations_table/BUILD | 2 ++ .../operations_table_data_provider.ts | 4 ++-- .../components/framework_op_stats/stats_table/BUILD | 2 ++ .../stats_table/stats_table_data_provider.ts | 10 +++++----- frontend/app/components/graph_viewer/BUILD | 1 + .../app/components/graph_viewer/graph_config/BUILD | 1 + frontend/app/components/hlo_stats/BUILD | 2 ++ frontend/app/components/hlo_stats/hlo_stats.ts | 4 ++-- frontend/app/components/inference_profile/BUILD | 1 + frontend/app/components/input_pipeline/BUILD | 1 + .../components/input_pipeline/analysis_summary/BUILD | 1 + .../input_pipeline/device_side_analysis_detail/BUILD | 2 ++ .../device_side_analysis_detail_data_provider.ts | 2 +- .../input_pipeline/host_side_analysis_detail/BUILD | 2 ++ .../host_side_analysis_detail_table_data_provider.ts | 2 +- frontend/app/components/kernel_stats/BUILD | 1 + .../components/kernel_stats/kernel_stats_table/BUILD | 2 ++ frontend/app/components/main_page/BUILD | 1 + frontend/app/components/memory_profile/BUILD | 1 + .../memory_profile/memory_breakdown_table/BUILD | 2 ++ .../memory_profile/memory_profile_summary/BUILD | 1 + .../memory_profile/memory_timeline_graph/BUILD | 1 + frontend/app/components/memory_viewer/BUILD | 2 ++ .../components/memory_viewer/buffer_details/BUILD | 1 + .../components/memory_viewer/max_heap_chart/BUILD | 1 + .../memory_viewer/memory_viewer_main/BUILD | 1 + .../memory_viewer/program_order_chart/BUILD | 1 + frontend/app/components/op_profile/BUILD | 2 ++ frontend/app/components/op_profile/op_details/BUILD | 1 + frontend/app/components/op_profile/op_table/BUILD | 1 + .../app/components/op_profile/op_table_entry/BUILD | 1 + frontend/app/components/overview_page/BUILD | 2 ++ .../overview_page/inference_latency_chart/BUILD | 1 + .../normalized_accelerator_performance_view/BUILD | 1 + .../overview_page/performance_summary/BUILD | 1 + .../overview_page/recommendation_result_view/BUILD | 2 ++ .../recommendation_result_view.ts | 6 +++--- .../overview_page/run_environment_view/BUILD | 1 + .../components/overview_page/step_time_graph/BUILD | 1 + .../app/components/overview_page/top_ops_table/BUILD | 1 + frontend/app/components/pod_viewer/BUILD | 2 ++ frontend/app/components/pod_viewer/pod_viewer.ts | 2 +- .../components/pod_viewer/pod_viewer_details/BUILD | 1 + .../app/components/pod_viewer/stack_bar_chart/BUILD | 1 + .../app/components/pod_viewer/topology_graph/BUILD | 2 ++ .../roofline_model/operation_level_analysis/BUILD | 2 ++ .../operation_level_analysis.ts | 2 +- .../roofline_model/program_level_analysis/BUILD | 2 ++ .../program_level_analysis/program_level_analysis.ts | 2 +- frontend/app/components/sidenav/BUILD | 1 + .../tf_data_bottleneck_analysis.ts | 2 +- frontend/app/components/trace_viewer/BUILD | 1 + .../app/services/data_dispatcher/data_dispatcher.ts | 8 ++++---- plugin/tensorboard_plugin_profile/convert/BUILD | 12 ++++++------ plugin/tensorboard_plugin_profile/demo/BUILD | 2 +- 71 files changed, 106 insertions(+), 31 deletions(-) rename defs/{BUILD.bazel => BUILD} (100%) diff --git a/defs/BUILD.bazel b/defs/BUILD similarity index 100% rename from defs/BUILD.bazel rename to defs/BUILD diff --git a/frontend/app/BUILD b/frontend/app/BUILD index 174fd2a3..e373e8f8 100644 --- a/frontend/app/BUILD +++ b/frontend/app/BUILD @@ -35,5 +35,6 @@ xprof_ng_module( sass_binary( name = "app_css", src = "app.scss", + # stack = False, sourcemap = False, ) diff --git a/frontend/app/components/capture_profile/BUILD b/frontend/app/components/capture_profile/BUILD index 7d269165..ce2c2a45 100644 --- a/frontend/app/components/capture_profile/BUILD +++ b/frontend/app/components/capture_profile/BUILD @@ -33,6 +33,7 @@ xprof_ng_module( sass_binary( name = "capture_profile_css", src = "capture_profile.scss", + # stack = False, sourcemap = False, deps = [ "@org_xprof//frontend/app/styles:common", diff --git a/frontend/app/components/capture_profile/capture_profile_dialog/BUILD b/frontend/app/components/capture_profile/capture_profile_dialog/BUILD index 8d2061cc..28385a7b 100644 --- a/frontend/app/components/capture_profile/capture_profile_dialog/BUILD +++ b/frontend/app/components/capture_profile/capture_profile_dialog/BUILD @@ -33,6 +33,7 @@ xprof_ng_module( sass_binary( name = "capture_profile_dialog_css", src = "capture_profile_dialog.scss", + # stack = False, sourcemap = False, deps = [ "@org_xprof//frontend/app/styles:common", diff --git a/frontend/app/components/chart/default_data_provider.ts b/frontend/app/components/chart/default_data_provider.ts index 9b1cc743..1a9540f4 100644 --- a/frontend/app/components/chart/default_data_provider.ts +++ b/frontend/app/components/chart/default_data_provider.ts @@ -79,7 +79,7 @@ export class DefaultDataProvider implements ChartDataProvider { /** A chart data provider that accepts array data. */ export class ArrayDataProvider extends DefaultDataProvider { - parseData(data: SimpleDataTable|Array>|null) { + override parseData(data: SimpleDataTable|Array>|null) { if (data) { /* tslint:disable no-any */ this.dataTable = google.visualization.arrayToDataTable(data as any[]); @@ -101,7 +101,7 @@ export class ReplicaGroupDataProvider extends DefaultDataProvider { hloOpNameIndex?: number; // 'hlo_op_expression' column selfTimeIndex?: number; // 'total_self_time' column - parseData(data: SimpleDataTable) { + override parseData(data: SimpleDataTable) { const rowWithReplicaGroups: google.visualization.DataObjectRow[] = []; if (!data || !data.cols || !data.rows) return; diff --git a/frontend/app/components/chart/org_chart/BUILD b/frontend/app/components/chart/org_chart/BUILD index 6d7252c3..24d339a7 100644 --- a/frontend/app/components/chart/org_chart/BUILD +++ b/frontend/app/components/chart/org_chart/BUILD @@ -22,5 +22,6 @@ xprof_ng_module( sass_binary( name = "org_chart_css", src = "org_chart.scss", + # stack = False, sourcemap = False, ) diff --git a/frontend/app/components/chart/table/BUILD b/frontend/app/components/chart/table/BUILD index 005440b2..e542cc9f 100644 --- a/frontend/app/components/chart/table/BUILD +++ b/frontend/app/components/chart/table/BUILD @@ -25,5 +25,6 @@ xprof_ng_module( sass_binary( name = "table_css", src = "table.scss", + # stack = False, sourcemap = False, ) diff --git a/frontend/app/components/controls/category_filter/BUILD b/frontend/app/components/controls/category_filter/BUILD index 4ca36aa9..3af7a768 100644 --- a/frontend/app/components/controls/category_filter/BUILD +++ b/frontend/app/components/controls/category_filter/BUILD @@ -26,5 +26,6 @@ xprof_ng_module( sass_binary( name = "category_filter_css", src = "category_filter.scss", + # stack = False, sourcemap = False, ) diff --git a/frontend/app/components/controls/export_as_csv/BUILD b/frontend/app/components/controls/export_as_csv/BUILD index e0ef146d..9389d61c 100644 --- a/frontend/app/components/controls/export_as_csv/BUILD +++ b/frontend/app/components/controls/export_as_csv/BUILD @@ -25,6 +25,7 @@ xprof_ng_module( sass_binary( name = "export_as_csv_css", src = "export_as_csv.scss", + # stack = True, sourcemap = False, deps = [ "@org_xprof//frontend/app/styles:common", diff --git a/frontend/app/components/controls/string_filter/BUILD b/frontend/app/components/controls/string_filter/BUILD index 662a5741..b1488e04 100644 --- a/frontend/app/components/controls/string_filter/BUILD +++ b/frontend/app/components/controls/string_filter/BUILD @@ -13,6 +13,7 @@ xprof_ng_module( "string_filter.ng.html", "string_filter_css", ], + # strict_templates = False, deps = [ "@npm//@angular/common", "@npm//@angular/core", @@ -26,6 +27,7 @@ xprof_ng_module( sass_binary( name = "string_filter_css", src = "string_filter.scss", + # stack = False, sourcemap = False, deps = [ "@org_xprof//frontend/app/styles:common", diff --git a/frontend/app/components/dcn_collective_stats/BUILD b/frontend/app/components/dcn_collective_stats/BUILD index 564e7dc8..1a23fb1a 100644 --- a/frontend/app/components/dcn_collective_stats/BUILD +++ b/frontend/app/components/dcn_collective_stats/BUILD @@ -13,6 +13,7 @@ xprof_ng_module( ":dcn_collective_stats_css", "dcn_collective_stats.ng.html", ], + # strict_templates = False, deps = [ "@npm//@angular/common", "@npm//@angular/core", @@ -35,6 +36,7 @@ xprof_ng_module( sass_binary( name = "dcn_collective_stats_css", src = "dcn_collective_stats.scss", + # stack = False, sourcemap = False, deps = [ "@org_xprof//frontend/app/styles:common", diff --git a/frontend/app/components/diagnostics_view/BUILD b/frontend/app/components/diagnostics_view/BUILD index 5d6231fd..1d1bfc77 100644 --- a/frontend/app/components/diagnostics_view/BUILD +++ b/frontend/app/components/diagnostics_view/BUILD @@ -22,6 +22,7 @@ xprof_ng_module( sass_binary( name = "diagnostics_view_css", src = "diagnostics_view.scss", + # stack = False, sourcemap = False, deps = [ "@org_xprof//frontend/app/styles:common", diff --git a/frontend/app/components/empty_page/BUILD b/frontend/app/components/empty_page/BUILD index 5f75c963..fec8720b 100644 --- a/frontend/app/components/empty_page/BUILD +++ b/frontend/app/components/empty_page/BUILD @@ -23,6 +23,7 @@ xprof_ng_module( sass_binary( name = "empty_page_css", src = "empty_page.scss", + # stack = False, sourcemap = False, deps = [ "@org_xprof//frontend/app/styles:common", diff --git a/frontend/app/components/framework_op_stats/BUILD b/frontend/app/components/framework_op_stats/BUILD index 2db9328f..ef5c45fd 100644 --- a/frontend/app/components/framework_op_stats/BUILD +++ b/frontend/app/components/framework_op_stats/BUILD @@ -31,6 +31,7 @@ xprof_ng_module( ":framework_op_stats_css", "framework_op_stats.ng.html", ], + # strict_templates = False, deps = [ "@npm//@angular/core", "@npm//@ngrx/store", @@ -58,6 +59,7 @@ xprof_ng_module( sass_binary( name = "framework_op_stats_css", src = "framework_op_stats.scss", + # stack = False, sourcemap = False, deps = [ "@org_xprof//frontend/app/styles:common", diff --git a/frontend/app/components/framework_op_stats/flop_rate_chart/BUILD b/frontend/app/components/framework_op_stats/flop_rate_chart/BUILD index a719bb78..1e62800b 100644 --- a/frontend/app/components/framework_op_stats/flop_rate_chart/BUILD +++ b/frontend/app/components/framework_op_stats/flop_rate_chart/BUILD @@ -13,6 +13,7 @@ xprof_ng_module( ":flop_rate_chart_css", "flop_rate_chart.ng.html", ], + # strict_templates = False, deps = [ "@npm//@angular/core", "@org_xprof//frontend/app/common/interfaces", @@ -27,5 +28,6 @@ xprof_ng_module( sass_binary( name = "flop_rate_chart_css", src = "flop_rate_chart.scss", + # stack = False, sourcemap = False, ) diff --git a/frontend/app/components/framework_op_stats/model_properties/BUILD b/frontend/app/components/framework_op_stats/model_properties/BUILD index 1e95ac53..763eb762 100644 --- a/frontend/app/components/framework_op_stats/model_properties/BUILD +++ b/frontend/app/components/framework_op_stats/model_properties/BUILD @@ -22,5 +22,6 @@ xprof_ng_module( sass_binary( name = "model_properties_css", src = "model_properties.scss", + # stack = False, sourcemap = False, ) diff --git a/frontend/app/components/framework_op_stats/operations_table/BUILD b/frontend/app/components/framework_op_stats/operations_table/BUILD index 1e63bb79..8b60dbda 100644 --- a/frontend/app/components/framework_op_stats/operations_table/BUILD +++ b/frontend/app/components/framework_op_stats/operations_table/BUILD @@ -14,6 +14,7 @@ xprof_ng_module( ":operations_table_css", "operations_table.ng.html", ], + # strict_templates = False, deps = [ ":operations_table_data_provider", "@npm//@angular/core", @@ -42,6 +43,7 @@ ts_library( sass_binary( name = "operations_table_css", src = "operations_table.scss", + # stack = False, sourcemap = False, deps = [ "@org_xprof//frontend/app/styles:common", diff --git a/frontend/app/components/framework_op_stats/operations_table/operations_table_data_provider.ts b/frontend/app/components/framework_op_stats/operations_table/operations_table_data_provider.ts index 04a8dd76..29affcd2 100644 --- a/frontend/app/components/framework_op_stats/operations_table/operations_table_data_provider.ts +++ b/frontend/app/components/framework_op_stats/operations_table/operations_table_data_provider.ts @@ -27,7 +27,7 @@ export class OperationsTableDataProvider extends DefaultDataProvider { diffData ? new google.visualization.DataTable(diffData) : undefined; } - process(): google.visualization.DataTable|google.visualization.DataView|null { + override process(): google.visualization.DataTable|google.visualization.DataView|null { if (!this.dataTable || (this.opExecutor !== OpExecutor.DEVICE && this.opExecutor !== OpExecutor.HOST)) { @@ -115,7 +115,7 @@ export class OperationsTableDataProvider extends DefaultDataProvider { return dataView; } - getOptions(): ChartOptions|null { + override getOptions(): ChartOptions|null { return this.options; } diff --git a/frontend/app/components/framework_op_stats/stats_table/BUILD b/frontend/app/components/framework_op_stats/stats_table/BUILD index 5d7751a1..1622d58d 100644 --- a/frontend/app/components/framework_op_stats/stats_table/BUILD +++ b/frontend/app/components/framework_op_stats/stats_table/BUILD @@ -13,6 +13,7 @@ xprof_ng_module( ":stats_table_css", "stats_table.ng.html", ], + # strict_templates = False, deps = [ ":stats_table_data_provider", "@npm//@angular/core", @@ -42,6 +43,7 @@ xprof_ng_module( sass_binary( name = "stats_table_css", src = "stats_table.scss", + # stack = False, sourcemap = False, deps = [ "@org_xprof//frontend/app/styles:common", diff --git a/frontend/app/components/framework_op_stats/stats_table/stats_table_data_provider.ts b/frontend/app/components/framework_op_stats/stats_table/stats_table_data_provider.ts index 390f353c..39f24d61 100644 --- a/frontend/app/components/framework_op_stats/stats_table/stats_table_data_provider.ts +++ b/frontend/app/components/framework_op_stats/stats_table/stats_table_data_provider.ts @@ -42,7 +42,7 @@ export class StatsTableDataProvider extends DefaultDataProvider { private readonly totalOperationsChanged = new EventEmitter(); - setChart(chart: ChartClass) { + override setChart(chart: ChartClass) { this.chart = chart; google.visualization.events.addListener( this.chart, 'sort', (event: SortEvent) => { @@ -52,7 +52,7 @@ export class StatsTableDataProvider extends DefaultDataProvider { }); } - parseData(data: SimpleDataTable|Array>|null) { + override parseData(data: SimpleDataTable|Array>|null) { if (!data) return; const dataTable = new google.visualization.DataTable(data); if (this.hasDiff && this.diffTable) { @@ -68,14 +68,14 @@ export class StatsTableDataProvider extends DefaultDataProvider { undefined; } - setFilters(filters: google.visualization.DataTableCellFilter[]) { + override setFilters(filters: google.visualization.DataTableCellFilter[]) { this.filters = filters; if (this.dataTable) { this.update.emit(); } } - process(): google.visualization.DataTable|google.visualization.DataView|null { + override process(): google.visualization.DataTable|google.visualization.DataView|null { if (!this.dataTable) { return null; } @@ -101,7 +101,7 @@ export class StatsTableDataProvider extends DefaultDataProvider { return dataView; } - getOptions(): ChartOptions|null { + override getOptions(): ChartOptions|null { this.options.sortAscending = this.sortAscending; this.options.sortColumn = this.sortColumn; return this.options; diff --git a/frontend/app/components/graph_viewer/BUILD b/frontend/app/components/graph_viewer/BUILD index abecfc27..583614e2 100644 --- a/frontend/app/components/graph_viewer/BUILD +++ b/frontend/app/components/graph_viewer/BUILD @@ -36,6 +36,7 @@ xprof_ng_module( sass_binary( name = "graph_viewer_css", src = "graph_viewer.scss", + # stack = True, sourcemap = False, deps = [ "@org_xprof//frontend/app/styles:common", diff --git a/frontend/app/components/graph_viewer/graph_config/BUILD b/frontend/app/components/graph_viewer/graph_config/BUILD index beb495ac..3204c231 100644 --- a/frontend/app/components/graph_viewer/graph_config/BUILD +++ b/frontend/app/components/graph_viewer/graph_config/BUILD @@ -34,6 +34,7 @@ xprof_ng_module( sass_binary( name = "graph_config_css", src = "graph_config.scss", + # stack = True, sourcemap = False, deps = [ "@org_xprof//frontend/app/styles:common", diff --git a/frontend/app/components/hlo_stats/BUILD b/frontend/app/components/hlo_stats/BUILD index 4b5c2621..020279fb 100644 --- a/frontend/app/components/hlo_stats/BUILD +++ b/frontend/app/components/hlo_stats/BUILD @@ -13,6 +13,7 @@ xprof_ng_module( ":hlo_stats_css", "hlo_stats.ng.html", ], + # strict_templates = False, deps = [ "@npm//@angular/core", "@npm//@angular/forms", @@ -44,6 +45,7 @@ xprof_ng_module( sass_binary( name = "hlo_stats_css", src = "hlo_stats.scss", + # stack = True, sourcemap = False, deps = [ "@org_xprof//frontend/app/styles:common", diff --git a/frontend/app/components/hlo_stats/hlo_stats.ts b/frontend/app/components/hlo_stats/hlo_stats.ts index 3b73361a..5c9e0c11 100644 --- a/frontend/app/components/hlo_stats/hlo_stats.ts +++ b/frontend/app/components/hlo_stats/hlo_stats.ts @@ -192,7 +192,7 @@ export class HloStats extends Dashboard implements OnDestroy { }; } - updateView() { + override updateView() { this.dataInfoForTable = { ...this.dataInfoForTable, filters: this.getFilters(), @@ -247,7 +247,7 @@ export class HloStats extends Dashboard implements OnDestroy { this.dataInfoForTable.dataProvider.notifyCharts(); } - parseData(data: SimpleDataTable | null) { + override parseData(data: SimpleDataTable | null) { if (!data) return; // Five charts share one DataProvider. In order to prevent DataTable from // being created multiple times, it calls DataProvider function directly. diff --git a/frontend/app/components/inference_profile/BUILD b/frontend/app/components/inference_profile/BUILD index 36cfc061..f646af9e 100644 --- a/frontend/app/components/inference_profile/BUILD +++ b/frontend/app/components/inference_profile/BUILD @@ -13,6 +13,7 @@ xprof_ng_module( ":inference_profile_css", "inference_profile.ng.html", ], + # strict_templates = False, deps = [ "@npm//@angular/common", "@npm//@angular/core", diff --git a/frontend/app/components/input_pipeline/BUILD b/frontend/app/components/input_pipeline/BUILD index d1a14b9c..7b44f3cd 100644 --- a/frontend/app/components/input_pipeline/BUILD +++ b/frontend/app/components/input_pipeline/BUILD @@ -33,6 +33,7 @@ xprof_ng_module( sass_binary( name = "input_pipeline_css", src = "input_pipeline.scss", + # stack = False, sourcemap = False, deps = [ "@org_xprof//frontend/app/styles:common", diff --git a/frontend/app/components/input_pipeline/analysis_summary/BUILD b/frontend/app/components/input_pipeline/analysis_summary/BUILD index c21f573a..d26919a6 100644 --- a/frontend/app/components/input_pipeline/analysis_summary/BUILD +++ b/frontend/app/components/input_pipeline/analysis_summary/BUILD @@ -22,6 +22,7 @@ xprof_ng_module( sass_binary( name = "analysis_summary_css", src = "analysis_summary.scss", + # stack = False, sourcemap = False, deps = [ "@org_xprof//frontend/app/styles:common", diff --git a/frontend/app/components/input_pipeline/device_side_analysis_detail/BUILD b/frontend/app/components/input_pipeline/device_side_analysis_detail/BUILD index a2f05eeb..1574a500 100644 --- a/frontend/app/components/input_pipeline/device_side_analysis_detail/BUILD +++ b/frontend/app/components/input_pipeline/device_side_analysis_detail/BUILD @@ -14,6 +14,7 @@ xprof_ng_module( ":device_side_analysis_detail_css", "device_side_analysis_detail.ng.html", ], + # strict_templates = False, deps = [ ":device_side_analysis_detail_data_provider", "@npm//@angular/core", @@ -37,6 +38,7 @@ ts_library( sass_binary( name = "device_side_analysis_detail_css", src = "device_side_analysis_detail.scss", + # stack = False, sourcemap = False, deps = [ "@org_xprof//frontend/app/styles:common", diff --git a/frontend/app/components/input_pipeline/device_side_analysis_detail/device_side_analysis_detail_data_provider.ts b/frontend/app/components/input_pipeline/device_side_analysis_detail/device_side_analysis_detail_data_provider.ts index dd516ed5..d0578ff2 100644 --- a/frontend/app/components/input_pipeline/device_side_analysis_detail/device_side_analysis_detail_data_provider.ts +++ b/frontend/app/components/input_pipeline/device_side_analysis_detail/device_side_analysis_detail_data_provider.ts @@ -9,7 +9,7 @@ export class DeviceSideAnalysisDetailDataProvider extends DefaultDataProvider { this.columnIds = columnIds; } - parseData(data: SimpleDataTable|Array>|null) { + override parseData(data: SimpleDataTable|Array>|null) { if (!data) return; const dataTable = new google.visualization.DataTable(data); diff --git a/frontend/app/components/input_pipeline/host_side_analysis_detail/BUILD b/frontend/app/components/input_pipeline/host_side_analysis_detail/BUILD index 2b787b46..9b695f68 100644 --- a/frontend/app/components/input_pipeline/host_side_analysis_detail/BUILD +++ b/frontend/app/components/input_pipeline/host_side_analysis_detail/BUILD @@ -13,6 +13,7 @@ xprof_ng_module( ":host_side_analysis_detail_css", "host_side_analysis_detail.ng.html", ], + # strict_templates = False, deps = [ ":host_side_analysis_detail_table_data_provider", "@npm//@angular/core", @@ -40,6 +41,7 @@ xprof_ng_module( sass_binary( name = "host_side_analysis_detail_css", src = "host_side_analysis_detail.scss", + # stack = False, sourcemap = False, deps = [ "@org_xprof//frontend/app/styles:common", diff --git a/frontend/app/components/input_pipeline/host_side_analysis_detail/host_side_analysis_detail_table_data_provider.ts b/frontend/app/components/input_pipeline/host_side_analysis_detail/host_side_analysis_detail_table_data_provider.ts index 804e8f7e..d7467d04 100644 --- a/frontend/app/components/input_pipeline/host_side_analysis_detail/host_side_analysis_detail_table_data_provider.ts +++ b/frontend/app/components/input_pipeline/host_side_analysis_detail/host_side_analysis_detail_table_data_provider.ts @@ -8,7 +8,7 @@ export class HostSideAnalysisDetailTableDataProvider extends DefaultDataProvider { private readonly hasHostOpsChanged = new EventEmitter(); - parseData(data: SimpleDataTable|Array>|null) { + override parseData(data: SimpleDataTable|Array>|null) { if (!data) return; const dataTable = new google.visualization.DataTable(data); if (dataTable.getNumberOfRows() < 1) { diff --git a/frontend/app/components/kernel_stats/BUILD b/frontend/app/components/kernel_stats/BUILD index 4f689571..6ced3209 100644 --- a/frontend/app/components/kernel_stats/BUILD +++ b/frontend/app/components/kernel_stats/BUILD @@ -44,6 +44,7 @@ xprof_ng_module( sass_binary( name = "kernel_stats_css", src = "kernel_stats.scss", + # stack = False, sourcemap = False, deps = [ "@org_xprof//frontend/app/styles:common", diff --git a/frontend/app/components/kernel_stats/kernel_stats_table/BUILD b/frontend/app/components/kernel_stats/kernel_stats_table/BUILD index b1cf8b59..0119d3cc 100644 --- a/frontend/app/components/kernel_stats/kernel_stats_table/BUILD +++ b/frontend/app/components/kernel_stats/kernel_stats_table/BUILD @@ -13,6 +13,7 @@ xprof_ng_module( ":kernel_stats_table_css", "kernel_stats_table.ng.html", ], + # strict_templates = False, deps = [ "@npm//@angular/core", "@npm//@types/google.visualization", @@ -26,6 +27,7 @@ xprof_ng_module( sass_binary( name = "kernel_stats_table_css", src = "kernel_stats_table.scss", + # stack = False, sourcemap = False, deps = [ "@org_xprof//frontend/app/styles:common", diff --git a/frontend/app/components/main_page/BUILD b/frontend/app/components/main_page/BUILD index 6dfaf74b..2763afba 100644 --- a/frontend/app/components/main_page/BUILD +++ b/frontend/app/components/main_page/BUILD @@ -49,6 +49,7 @@ xprof_ng_module( sass_binary( name = "main_page_css", src = "main_page.scss", + # stack = False, sourcemap = False, deps = [ "@org_xprof//frontend/app/styles:common", diff --git a/frontend/app/components/memory_profile/BUILD b/frontend/app/components/memory_profile/BUILD index 241b2b3d..89d922a1 100644 --- a/frontend/app/components/memory_profile/BUILD +++ b/frontend/app/components/memory_profile/BUILD @@ -46,6 +46,7 @@ ts_library( sass_binary( name = "memory_profile_css", src = "memory_profile.scss", + # stack = False, sourcemap = False, deps = [ ":memory_profile_common", diff --git a/frontend/app/components/memory_profile/memory_breakdown_table/BUILD b/frontend/app/components/memory_profile/memory_breakdown_table/BUILD index fb308ec3..5f8bdc33 100644 --- a/frontend/app/components/memory_profile/memory_breakdown_table/BUILD +++ b/frontend/app/components/memory_profile/memory_breakdown_table/BUILD @@ -13,6 +13,7 @@ xprof_ng_module( ":memory_breakdown_table_css", "memory_breakdown_table.ng.html", ], + # strict_templates = False, deps = [ "@npm//@angular/core", "@npm//@types/google.visualization", @@ -28,6 +29,7 @@ xprof_ng_module( sass_binary( name = "memory_breakdown_table_css", src = "memory_breakdown_table.scss", + # stack = False, sourcemap = False, deps = [ "@org_xprof//frontend/app/styles:common", diff --git a/frontend/app/components/memory_profile/memory_profile_summary/BUILD b/frontend/app/components/memory_profile/memory_profile_summary/BUILD index 4b1d3ae7..4a454ee1 100644 --- a/frontend/app/components/memory_profile/memory_profile_summary/BUILD +++ b/frontend/app/components/memory_profile/memory_profile_summary/BUILD @@ -26,6 +26,7 @@ xprof_ng_module( sass_binary( name = "memory_profile_summary_css", src = "memory_profile_summary.scss", + # stack = False, sourcemap = False, deps = [ "@org_xprof//frontend/app/styles:common", diff --git a/frontend/app/components/memory_profile/memory_timeline_graph/BUILD b/frontend/app/components/memory_profile/memory_timeline_graph/BUILD index ffa9bece..91744c38 100644 --- a/frontend/app/components/memory_profile/memory_timeline_graph/BUILD +++ b/frontend/app/components/memory_profile/memory_timeline_graph/BUILD @@ -25,6 +25,7 @@ xprof_ng_module( sass_binary( name = "memory_timeline_graph_css", src = "memory_timeline_graph.scss", + # stack = False, sourcemap = False, deps = [ "@org_xprof//frontend/app/styles:common", diff --git a/frontend/app/components/memory_viewer/BUILD b/frontend/app/components/memory_viewer/BUILD index f009ac44..63fa7161 100644 --- a/frontend/app/components/memory_viewer/BUILD +++ b/frontend/app/components/memory_viewer/BUILD @@ -29,7 +29,9 @@ xprof_ng_module( sass_binary( name = "memory_viewer_css", src = "memory_viewer.scss", + # stack = False, sourcemap = False, + # strict_deps = False, deps = [ "@org_xprof//frontend/app/styles:common", ], diff --git a/frontend/app/components/memory_viewer/buffer_details/BUILD b/frontend/app/components/memory_viewer/buffer_details/BUILD index d6687f60..08f6c893 100644 --- a/frontend/app/components/memory_viewer/buffer_details/BUILD +++ b/frontend/app/components/memory_viewer/buffer_details/BUILD @@ -28,6 +28,7 @@ xprof_ng_module( sass_binary( name = "buffer_details_css", src = "buffer_details.scss", + # stack = False, sourcemap = False, deps = [ "@org_xprof//frontend/app/styles:common", diff --git a/frontend/app/components/memory_viewer/max_heap_chart/BUILD b/frontend/app/components/memory_viewer/max_heap_chart/BUILD index 70b81f7e..b214fde9 100644 --- a/frontend/app/components/memory_viewer/max_heap_chart/BUILD +++ b/frontend/app/components/memory_viewer/max_heap_chart/BUILD @@ -25,6 +25,7 @@ xprof_ng_module( sass_binary( name = "max_heap_chart_css", src = "max_heap_chart.scss", + # stack = False, sourcemap = False, deps = [ "@org_xprof//frontend/app/styles:common", diff --git a/frontend/app/components/memory_viewer/memory_viewer_main/BUILD b/frontend/app/components/memory_viewer/memory_viewer_main/BUILD index 37bddb21..306de204 100644 --- a/frontend/app/components/memory_viewer/memory_viewer_main/BUILD +++ b/frontend/app/components/memory_viewer/memory_viewer_main/BUILD @@ -35,6 +35,7 @@ xprof_ng_module( sass_binary( name = "memory_viewer_main_css", src = "memory_viewer_main.scss", + # stack = False, sourcemap = False, deps = [ "@org_xprof//frontend/app/styles:common", diff --git a/frontend/app/components/memory_viewer/program_order_chart/BUILD b/frontend/app/components/memory_viewer/program_order_chart/BUILD index 83170c02..61d4fd9b 100644 --- a/frontend/app/components/memory_viewer/program_order_chart/BUILD +++ b/frontend/app/components/memory_viewer/program_order_chart/BUILD @@ -26,6 +26,7 @@ xprof_ng_module( sass_binary( name = "program_order_chart_css", src = "program_order_chart.scss", + # stack = False, sourcemap = False, deps = [ "@org_xprof//frontend/app/styles:common", diff --git a/frontend/app/components/op_profile/BUILD b/frontend/app/components/op_profile/BUILD index 64600a53..0cbb32bf 100644 --- a/frontend/app/components/op_profile/BUILD +++ b/frontend/app/components/op_profile/BUILD @@ -14,6 +14,7 @@ xprof_ng_module( ":op_profile_css", "op_profile.ng.html", ], + # strict_templates = False, deps = [ ":op_profile_base", "@npm//@angular/core", @@ -50,6 +51,7 @@ ts_library( sass_binary( name = "op_profile_css", src = "op_profile.scss", + # stack = False, sourcemap = False, deps = [ ":op_profile_common", diff --git a/frontend/app/components/op_profile/op_details/BUILD b/frontend/app/components/op_profile/op_details/BUILD index 2d0f5ab5..88ee7622 100644 --- a/frontend/app/components/op_profile/op_details/BUILD +++ b/frontend/app/components/op_profile/op_details/BUILD @@ -33,6 +33,7 @@ xprof_ng_module( sass_binary( name = "op_details_css", src = "op_details.scss", + # stack = False, sourcemap = False, deps = [ "@org_xprof//frontend/app/styles:common", diff --git a/frontend/app/components/op_profile/op_table/BUILD b/frontend/app/components/op_profile/op_table/BUILD index b40141a4..4cf7bef5 100644 --- a/frontend/app/components/op_profile/op_table/BUILD +++ b/frontend/app/components/op_profile/op_table/BUILD @@ -27,6 +27,7 @@ xprof_ng_module( sass_binary( name = "op_table_css", src = "op_table.scss", + # stack = False, sourcemap = False, deps = [ "@org_xprof//frontend/app/components/op_profile:op_profile_common", diff --git a/frontend/app/components/op_profile/op_table_entry/BUILD b/frontend/app/components/op_profile/op_table_entry/BUILD index 5121b7a1..62628f51 100644 --- a/frontend/app/components/op_profile/op_table_entry/BUILD +++ b/frontend/app/components/op_profile/op_table_entry/BUILD @@ -26,6 +26,7 @@ xprof_ng_module( sass_binary( name = "op_table_entry_css", src = "op_table_entry.scss", + # stack = False, sourcemap = False, deps = [ "@org_xprof//frontend/app/components/op_profile:op_profile_common", diff --git a/frontend/app/components/overview_page/BUILD b/frontend/app/components/overview_page/BUILD index a341a5e6..98692f22 100644 --- a/frontend/app/components/overview_page/BUILD +++ b/frontend/app/components/overview_page/BUILD @@ -14,6 +14,7 @@ xprof_ng_module( ":overview_page_css", "overview_page.ng.html", ], + # strict_templates = False, deps = [ "@npm//@angular/common", "@npm//@angular/core", @@ -39,6 +40,7 @@ xprof_ng_module( sass_binary( name = "overview_page_css", src = "overview_page.scss", + # stack = False, sourcemap = False, deps = [ "@org_xprof//frontend/app/styles:common", diff --git a/frontend/app/components/overview_page/inference_latency_chart/BUILD b/frontend/app/components/overview_page/inference_latency_chart/BUILD index ad951578..a3f76db8 100644 --- a/frontend/app/components/overview_page/inference_latency_chart/BUILD +++ b/frontend/app/components/overview_page/inference_latency_chart/BUILD @@ -24,6 +24,7 @@ xprof_ng_module( sass_binary( name = "inference_latency_chart_css", src = "inference_latency_chart.scss", + # stack = True, sourcemap = False, deps = [ "@org_xprof//frontend/app/styles:common", diff --git a/frontend/app/components/overview_page/normalized_accelerator_performance_view/BUILD b/frontend/app/components/overview_page/normalized_accelerator_performance_view/BUILD index 718c8672..54c2d738 100644 --- a/frontend/app/components/overview_page/normalized_accelerator_performance_view/BUILD +++ b/frontend/app/components/overview_page/normalized_accelerator_performance_view/BUILD @@ -24,6 +24,7 @@ xprof_ng_module( sass_binary( name = "normalized_accelerator_performance_view_css", src = "normalized_accelerator_performance_view.scss", + # stack = False, sourcemap = False, deps = [ "@org_xprof//frontend/app/styles:common", diff --git a/frontend/app/components/overview_page/performance_summary/BUILD b/frontend/app/components/overview_page/performance_summary/BUILD index 6be88476..ff5b719c 100644 --- a/frontend/app/components/overview_page/performance_summary/BUILD +++ b/frontend/app/components/overview_page/performance_summary/BUILD @@ -26,6 +26,7 @@ xprof_ng_module( sass_binary( name = "performance_summary_css", src = "performance_summary.scss", + # stack = False, sourcemap = False, deps = [ "@org_xprof//frontend/app/styles:common", diff --git a/frontend/app/components/overview_page/recommendation_result_view/BUILD b/frontend/app/components/overview_page/recommendation_result_view/BUILD index d81754af..505d1e9c 100644 --- a/frontend/app/components/overview_page/recommendation_result_view/BUILD +++ b/frontend/app/components/overview_page/recommendation_result_view/BUILD @@ -16,6 +16,7 @@ xprof_ng_module( ":recommendation_result_view_css", "recommendation_result_view.ng.html", ], + # strict_templates = False, deps = [ "@npm//@angular/common", "@npm//@angular/core", @@ -30,6 +31,7 @@ xprof_ng_module( sass_binary( name = "recommendation_result_view_css", src = "recommendation_result_view.scss", + # stack = False, sourcemap = False, deps = [ "@org_xprof//frontend/app/styles:common", diff --git a/frontend/app/components/overview_page/recommendation_result_view/recommendation_result_view.ts b/frontend/app/components/overview_page/recommendation_result_view/recommendation_result_view.ts index cfcabe6c..050fffd7 100644 --- a/frontend/app/components/overview_page/recommendation_result_view/recommendation_result_view.ts +++ b/frontend/app/components/overview_page/recommendation_result_view/recommendation_result_view.ts @@ -58,7 +58,7 @@ export class RecommendationResultView extends RecommendationResultViewCommon { return defaultValue; } - parseStatements() { + override parseStatements() { this.statements = []; STATEMENT_INFO.forEach(info => { const prop = this.getRecommendationResultProp(info.id); @@ -68,7 +68,7 @@ export class RecommendationResultView extends RecommendationResultViewCommon { }); } - parseTips() { + override parseTips() { const data = this.recommendationResult || DEFAULT_SIMPLE_DATA_TABLE; const hostTips: string[] = []; const deviceTips: string[] = []; @@ -125,7 +125,7 @@ export class RecommendationResultView extends RecommendationResultViewCommon { this.tipInfoArray = tipInfoArray.filter(tipInfo => tipInfo.tips.length > 0); } - onTipsClick(event: Event) { + override onTipsClick(event: Event) { if (!event || !event.target || (event.target as HTMLElement).tagName !== 'A') { return; diff --git a/frontend/app/components/overview_page/run_environment_view/BUILD b/frontend/app/components/overview_page/run_environment_view/BUILD index 817c96c1..e00a117c 100644 --- a/frontend/app/components/overview_page/run_environment_view/BUILD +++ b/frontend/app/components/overview_page/run_environment_view/BUILD @@ -23,6 +23,7 @@ xprof_ng_module( sass_binary( name = "run_environment_view_css", src = "run_environment_view.scss", + # stack = False, sourcemap = False, deps = [ "@org_xprof//frontend/app/styles:common", diff --git a/frontend/app/components/overview_page/step_time_graph/BUILD b/frontend/app/components/overview_page/step_time_graph/BUILD index 3aee8c54..d582f49c 100644 --- a/frontend/app/components/overview_page/step_time_graph/BUILD +++ b/frontend/app/components/overview_page/step_time_graph/BUILD @@ -24,6 +24,7 @@ xprof_ng_module( sass_binary( name = "step_time_graph_css", src = "step_time_graph.scss", + # stack = False, sourcemap = False, deps = [ "@org_xprof//frontend/app/styles:common", diff --git a/frontend/app/components/overview_page/top_ops_table/BUILD b/frontend/app/components/overview_page/top_ops_table/BUILD index 79f00049..63dff727 100644 --- a/frontend/app/components/overview_page/top_ops_table/BUILD +++ b/frontend/app/components/overview_page/top_ops_table/BUILD @@ -24,6 +24,7 @@ xprof_ng_module( sass_binary( name = "top_ops_table_css", src = "top_ops_table.scss", + # stack = False, sourcemap = False, deps = [ "@org_xprof//frontend/app/styles:common", diff --git a/frontend/app/components/pod_viewer/BUILD b/frontend/app/components/pod_viewer/BUILD index 36cc644e..366bf8f7 100644 --- a/frontend/app/components/pod_viewer/BUILD +++ b/frontend/app/components/pod_viewer/BUILD @@ -14,6 +14,7 @@ xprof_ng_module( ":pod_viewer_css", "pod_viewer.ng.html", ], + # strict_templates = False, deps = [ "@npm//@angular/core", "@npm//@angular/router", @@ -35,6 +36,7 @@ xprof_ng_module( sass_binary( name = "pod_viewer_css", src = "pod_viewer.scss", + # stack = False, sourcemap = False, deps = [ "@org_xprof//frontend/app/styles:common", diff --git a/frontend/app/components/pod_viewer/pod_viewer.ts b/frontend/app/components/pod_viewer/pod_viewer.ts index 29ee22c1..9fc928e3 100644 --- a/frontend/app/components/pod_viewer/pod_viewer.ts +++ b/frontend/app/components/pod_viewer/pod_viewer.ts @@ -22,7 +22,7 @@ export class PodViewer extends PodViewerCommon implements OnDestroy { private readonly destroyed = new ReplaySubject(1); constructor( route: ActivatedRoute, private readonly dataService: DataService, - readonly store: Store<{}>) { + override readonly store: Store<{}>) { super(store); route.params.pipe(takeUntil(this.destroyed)).subscribe((params) => { this.update(params as NavigationEvent); diff --git a/frontend/app/components/pod_viewer/pod_viewer_details/BUILD b/frontend/app/components/pod_viewer/pod_viewer_details/BUILD index 62c5055c..2681c650 100644 --- a/frontend/app/components/pod_viewer/pod_viewer_details/BUILD +++ b/frontend/app/components/pod_viewer/pod_viewer_details/BUILD @@ -29,6 +29,7 @@ xprof_ng_module( sass_binary( name = "pod_viewer_details_css", src = "pod_viewer_details.scss", + # stack = False, sourcemap = False, deps = [ "@org_xprof//frontend/app/styles:common", diff --git a/frontend/app/components/pod_viewer/stack_bar_chart/BUILD b/frontend/app/components/pod_viewer/stack_bar_chart/BUILD index 319979d8..1a34e48c 100644 --- a/frontend/app/components/pod_viewer/stack_bar_chart/BUILD +++ b/frontend/app/components/pod_viewer/stack_bar_chart/BUILD @@ -24,5 +24,6 @@ xprof_ng_module( sass_binary( name = "stack_bar_chart_css", src = "stack_bar_chart.scss", + # stack = False, sourcemap = False, ) diff --git a/frontend/app/components/pod_viewer/topology_graph/BUILD b/frontend/app/components/pod_viewer/topology_graph/BUILD index d263e6da..3f60a86c 100644 --- a/frontend/app/components/pod_viewer/topology_graph/BUILD +++ b/frontend/app/components/pod_viewer/topology_graph/BUILD @@ -13,6 +13,7 @@ xprof_ng_module( ":topology_graph_css", "topology_graph.ng.html", ], + # strict_templates = False, deps = [ "@npm//@angular/common", "@npm//@angular/core", @@ -34,6 +35,7 @@ xprof_ng_module( sass_binary( name = "topology_graph_css", src = "topology_graph.scss", + # stack = False, sourcemap = False, deps = [ "@org_xprof//frontend/app/styles:common", diff --git a/frontend/app/components/roofline_model/operation_level_analysis/BUILD b/frontend/app/components/roofline_model/operation_level_analysis/BUILD index 7f5942e6..b9b431ac 100644 --- a/frontend/app/components/roofline_model/operation_level_analysis/BUILD +++ b/frontend/app/components/roofline_model/operation_level_analysis/BUILD @@ -13,6 +13,7 @@ xprof_ng_module( ":operation_level_analysis_css", "operation_level_analysis.ng.html", ], + # strict_templates = False, deps = [ "@npm//@angular/core", "@org_xprof//frontend/app/common/constants:roofline_model_constants", @@ -32,5 +33,6 @@ xprof_ng_module( sass_binary( name = "operation_level_analysis_css", src = "operation_level_analysis.scss", + # stack = True, sourcemap = False, ) diff --git a/frontend/app/components/roofline_model/operation_level_analysis/operation_level_analysis.ts b/frontend/app/components/roofline_model/operation_level_analysis/operation_level_analysis.ts index 004992c2..62bdc505 100644 --- a/frontend/app/components/roofline_model/operation_level_analysis/operation_level_analysis.ts +++ b/frontend/app/components/roofline_model/operation_level_analysis/operation_level_analysis.ts @@ -90,7 +90,7 @@ export class OperationLevelAnalysis this.updateView(); } - parseData() { + override parseData() { // base data already preprocessed in parent component if (!this.rooflineModelData) { return; diff --git a/frontend/app/components/roofline_model/program_level_analysis/BUILD b/frontend/app/components/roofline_model/program_level_analysis/BUILD index 7cac3f91..c74bfb0a 100644 --- a/frontend/app/components/roofline_model/program_level_analysis/BUILD +++ b/frontend/app/components/roofline_model/program_level_analysis/BUILD @@ -13,6 +13,7 @@ xprof_ng_module( ":program_level_analysis_css", "program_level_analysis.ng.html", ], + # strict_templates = False, deps = [ "@npm//@angular/core", "@org_xprof//frontend/app/common/interfaces", @@ -29,5 +30,6 @@ xprof_ng_module( sass_binary( name = "program_level_analysis_css", src = "program_level_analysis.scss", + # stack = True, sourcemap = False, ) diff --git a/frontend/app/components/roofline_model/program_level_analysis/program_level_analysis.ts b/frontend/app/components/roofline_model/program_level_analysis/program_level_analysis.ts index b8bc40ee..b435b36c 100644 --- a/frontend/app/components/roofline_model/program_level_analysis/program_level_analysis.ts +++ b/frontend/app/components/roofline_model/program_level_analysis/program_level_analysis.ts @@ -62,7 +62,7 @@ export class ProgramLevelAnalysis this.updateView(); } - parseData() { + override parseData() { // base data already preprocessed in parent component if (!this.rooflineModelData) { return; diff --git a/frontend/app/components/sidenav/BUILD b/frontend/app/components/sidenav/BUILD index d1fda6a9..9df7dd89 100644 --- a/frontend/app/components/sidenav/BUILD +++ b/frontend/app/components/sidenav/BUILD @@ -36,6 +36,7 @@ xprof_ng_module( sass_binary( name = "sidenav_css", src = "sidenav.scss", + # stack = False, sourcemap = False, deps = [ "@org_xprof//frontend/app/styles:common", diff --git a/frontend/app/components/tf_data_bottleneck_analysis/tf_data_bottleneck_analysis.ts b/frontend/app/components/tf_data_bottleneck_analysis/tf_data_bottleneck_analysis.ts index 25e17b53..5f227cd3 100644 --- a/frontend/app/components/tf_data_bottleneck_analysis/tf_data_bottleneck_analysis.ts +++ b/frontend/app/components/tf_data_bottleneck_analysis/tf_data_bottleneck_analysis.ts @@ -124,7 +124,7 @@ export class TfDataBottleneckAnalysis extends Dashboard implements OnDestroy { }); } - updateView() { + override updateView() { super.updateView(); if (!this.dataView) { return; diff --git a/frontend/app/components/trace_viewer/BUILD b/frontend/app/components/trace_viewer/BUILD index ad34f41f..fa063976 100644 --- a/frontend/app/components/trace_viewer/BUILD +++ b/frontend/app/components/trace_viewer/BUILD @@ -29,5 +29,6 @@ xprof_ng_module( sass_binary( name = "trace_viewer_css", src = "trace_viewer.scss", + # stack = False, sourcemap = False, ) diff --git a/frontend/app/services/data_dispatcher/data_dispatcher.ts b/frontend/app/services/data_dispatcher/data_dispatcher.ts index ae5bf317..a0d2d055 100644 --- a/frontend/app/services/data_dispatcher/data_dispatcher.ts +++ b/frontend/app/services/data_dispatcher/data_dispatcher.ts @@ -20,11 +20,11 @@ export class DataDispatcher extends DataDispatcherBase { super(store); } - clearData(dataRequest: DataRequest) { + override clearData(dataRequest: DataRequest) { this.store.dispatch(this.getActions(dataRequest)); } - exportAsCsv(tool: string) { + override exportAsCsv(tool: string) { if (!!tool && tool === this.params.tag) { this.dataService.exportDataAsCSV( this.params.run, this.params.tag, this.params.host); @@ -32,7 +32,7 @@ export class DataDispatcher extends DataDispatcherBase { } // tslint:disable-next-line:no-any - load(dataRequest: DataRequest): Observable { + override load(dataRequest: DataRequest): Observable { const run = dataRequest.params.run || ''; const tag = dataRequest.params.tag || ''; const host = dataRequest.params.host || ''; @@ -48,7 +48,7 @@ export class DataDispatcher extends DataDispatcherBase { } // tslint:disable-next-line:no-any - parseData(dataRequest: DataRequest, data: any) { + override parseData(dataRequest: DataRequest, data: any) { if (dataRequest.type === DataRequestType.KERNEL_STATS) { data = (data || [{}])[0]; } diff --git a/plugin/tensorboard_plugin_profile/convert/BUILD b/plugin/tensorboard_plugin_profile/convert/BUILD index e450bde9..73de40fc 100644 --- a/plugin/tensorboard_plugin_profile/convert/BUILD +++ b/plugin/tensorboard_plugin_profile/convert/BUILD @@ -68,7 +68,7 @@ py_test( srcs_version = "PY2AND3", deps = [ ":input_pipeline_proto_to_gviz", - requirement("absl-py"), + requirement("absl-py"), # build_cleaner: keep; go/disable_tf2 "//third_party/py/google/protobuf:use_fast_cpp_protos", # Automatically added go/proto_python_upb_flip requirement("gviz_api"), "//:expect_tensorflow_installed", @@ -106,7 +106,7 @@ py_test( srcs_version = "PY2AND3", deps = [ ":overview_page_proto_to_gviz", - requirement("absl-py"), + requirement("absl-py"), # build_cleaner: keep; go/disable_tf2 "//third_party/py/google/protobuf:use_fast_cpp_protos", # Automatically added go/proto_python_upb_flip requirement("gviz_api"), "//:expect_tensorflow_installed", @@ -130,7 +130,7 @@ py_test( srcs_version = "PY2AND3", deps = [ ":tf_stats_proto_to_gviz", - requirement("absl-py"), + requirement("absl-py"), # build_cleaner: keep; go/disable_tf2 "//third_party/py/google/protobuf:use_fast_cpp_protos", # Automatically added go/proto_python_upb_flip requirement("gviz_api"), "//:expect_tensorflow_installed", @@ -156,7 +156,7 @@ py_test( srcs_version = "PY2AND3", deps = [ ":trace_events_json", - requirement("absl-py"), + requirement("absl-py"), # build_cleaner: keep; go/disable_tf2 "//:expect_tensorflow_installed", "//third_party/py/google/protobuf:use_fast_cpp_protos", # Automatically added go/proto_python_upb_flip "@org_xprof//plugin/tensorboard_plugin_profile/protobuf:protos_all_py_pb2", @@ -179,7 +179,7 @@ py_test( srcs_version = "PY2AND3", deps = [ ":kernel_stats_proto_to_gviz", - requirement("absl-py"), + requirement("absl-py"), # build_cleaner: keep; go/disable_tf2 "//third_party/py/google/protobuf:use_fast_cpp_protos", # Automatically added go/proto_python_upb_flip requirement("gviz_api"), "//:expect_tensorflow_installed", @@ -205,7 +205,7 @@ py_test( srcs_version = "PY2AND3", deps = [ ":tf_data_stats_proto_to_gviz", - requirement("absl-py"), + requirement("absl-py"), # build_cleaner: keep; go/disable_tf2 "//third_party/py/google/protobuf:use_fast_cpp_protos", # Automatically added go/proto_python_upb_flip requirement("gviz_api"), "//:expect_tensorflow_installed", diff --git a/plugin/tensorboard_plugin_profile/demo/BUILD b/plugin/tensorboard_plugin_profile/demo/BUILD index 0a470fdb..2e8febd4 100644 --- a/plugin/tensorboard_plugin_profile/demo/BUILD +++ b/plugin/tensorboard_plugin_profile/demo/BUILD @@ -28,7 +28,7 @@ py_binary( python_version = "PY3", srcs_version = "PY2AND3", deps = [ - requirement("absl-py"), + requirement("absl-py"), # build_cleaner: keep; go/disable_tf2 "//:expect_tensorflow_installed", "//third_party/py/google/protobuf:use_fast_cpp_protos", # Automatically added go/proto_python_upb_flip "@org_tensorflow_tensorboard//tensorboard/backend/event_processing:plugin_asset_util",