From 9218164812b297a56109055493e0d9936ffd83fb Mon Sep 17 00:00:00 2001
From: Feng Wang <wffw@google.com>
Date: Wed, 10 Apr 2024 11:02:26 -0700
Subject: [PATCH] add some internal changes

PiperOrigin-RevId: 623547261
---
 .../performance_summary.ts                    | 41 ++++++++++++++++++-
 .../protobuf/overview_page.proto              | 16 ++++++++
 2 files changed, 56 insertions(+), 1 deletion(-)

diff --git a/frontend/app/components/overview/performance_summary/performance_summary.ts b/frontend/app/components/overview/performance_summary/performance_summary.ts
index c2422988..eb391839 100644
--- a/frontend/app/components/overview/performance_summary/performance_summary.ts
+++ b/frontend/app/components/overview/performance_summary/performance_summary.ts
@@ -167,7 +167,46 @@ const TPU_SUMMARY_INFO: SummaryInfoConfig[] = [
     valueKey: 'memory_bw_utilization_relative_to_hw_limit',
   },
   {
-    title: 'Power Metrics',
+    title: 'Firmeware Power Metrics (Power/Timescale)',
+    tooltip:
+        'Max power consumption of different components/rails with different timescale.',
+    childrenInfoConfig: [
+      {
+        title: 'Max VDD Core FW PowerMeter PL1',
+        valueKey: 'fw_max_vdd_core_pl1_power_watts',
+      },
+      {
+        title: 'Max VDD Core FW PowerMeter PL2',
+        valueKey: 'fw_max_vdd_core_pl2_power_watts',
+      },
+      {
+        title: 'Max VDD Core FW PowerMeter PL3',
+        valueKey: 'fw_max_vdd_core_pl3_power_watts',
+      },
+      {
+        title: 'Max VDD Core FW PowerMeter PL4',
+        valueKey: 'fw_max_vdd_core_pl4_power_watts',
+      },
+      {
+        title: 'Max HBM FW PowerMeter PL1',
+        valueKey: 'fw_max_hbm_pl1_power_watts',
+      },
+      {
+        title: 'Max HBM FW PowerMeter PL2',
+        valueKey: 'fw_max_hbm_pl2_power_watts',
+      },
+      {
+        title: 'Max HBM FW PowerMeter PL3',
+        valueKey: 'fw_max_hbm_pl3_power_watts',
+      },
+      {
+        title: 'Max HBM FW PowerMeter PL4',
+        valueKey: 'fw_max_hbm_pl4_power_watts',
+      },
+    ]
+  },
+  {
+    title: 'SPI Sampler Power Metrics',
     tooltip:
         'Avg/Max power consumption of different components/rails, including max of moving average of window size of 100us/1ms/10ms.',
     getChildValues: (props) =>
diff --git a/plugin/tensorboard_plugin_profile/protobuf/overview_page.proto b/plugin/tensorboard_plugin_profile/protobuf/overview_page.proto
index b4770461..bdaa6021 100644
--- a/plugin/tensorboard_plugin_profile/protobuf/overview_page.proto
+++ b/plugin/tensorboard_plugin_profile/protobuf/overview_page.proto
@@ -77,6 +77,22 @@ message OverviewPageAnalysis {
   double sc_outfeed_time_ms_avg = 21;
   // Sparse core idle time in ms average.
   double sc_idle_time_ms_avg = 22;
+  // Max FW VDD Core PL1 power metrics in watts.
+  double fw_max_vdd_core_pl1_power_watts = 23;
+  // Max FW VDD Core PL2 power metrics in watts.
+  double fw_max_vdd_core_pl2_power_watts = 24;
+  // Max FW VDD Core PL3 power metrics in watts.
+  double fw_max_vdd_core_pl3_power_watts = 25;
+  // Max FW VDD Core PL4 power metrics in watts.
+  double fw_max_vdd_core_pl4_power_watts = 26;
+  // Max FW HBM PL1 power metrics in watts.
+  double fw_max_hbm_pl1_power_watts = 27;
+  // Max FW HBM PL2 power metrics in watts.
+  double fw_max_hbm_pl2_power_watts = 28;
+  // Max FW HBM PL3 power metrics in watts.
+  double fw_max_hbm_pl3_power_watts = 29;
+  // Max FW HBM PL4 power metrics in watts.
+  double fw_max_hbm_pl4_power_watts = 30;
   // END-INTERNAL
 }