Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a frame-ancestors allow list option to Content-Security-Policy #6573

Closed
wants to merge 1 commit into from

Conversation

peetahzee
Copy link

Motivation for features / changes

Add an allowlist to allow TensorBoard to embedded as an iframe in other apps

Technical description of changes

By default, browsers disallow any webpages to be iframed in other external apps unless a Content-Security-Policy frame-ancestors header is set. This change exposes an option to customize that header.

Screenshots of UI changes (or N/A)

N/A

Detailed steps to verify changes work correctly (as executed by you)

Added unit test and verified headers show up as expected.

Alternate designs / implementations considered (or N/A)

N/A

@bmd3k bmd3k self-requested a review September 12, 2023 16:49
@peetahzee
Copy link
Author

peetahzee commented Sep 12, 2023

Turns out this option is unnecessary. By default, not setting frame-ancestors means that all URLs are accepted as frame ancestors. In other words, as it is, TensorBoard can already be iframed by any page.

@peetahzee peetahzee closed this Sep 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant