Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

should handle the extension sync properly when it is within a repo #527

Closed
hoatle opened this issue Oct 30, 2018 · 1 comment
Closed

should handle the extension sync properly when it is within a repo #527

hoatle opened this issue Oct 30, 2018 · 1 comment

Comments

@hoatle
Copy link
Member

hoatle commented Oct 30, 2018

for example with this config:

 - _id: "entry-iorad-app"
      path:
        lookup: workspace
        extension: iorad/teracy-dev-iorad-app # convert from https://github.com/iorad/iorad/tree/develop/dev-setup
      location:
        git:
          remote:
            origin: [email protected]:iorad/iorad.git
            branch: develop
      require_version: ">= 0.1.0-SNAPSHOT"
      enabled: true
  • expected:
[TeracyDev::Location::GitSynch][INFO]: cd /Users/hoatle/iorad-dev-2/lib/../workspace/iorad && git checkout develop
iorad$ git remote -v
origin    [email protected]:iorad/iorad.git (fetch)
origin    [email protected]:iorad/iorad.git (push)
  • actual:
[TeracyDev::Location::GitSynch][INFO]: cd /Users/hoatle/iorad-dev-2/lib/../workspace/iorad/teracy-dev-iorad-app && git checkout master
/Users/hoatle/iorad-dev-2/lib/teracy-dev/location/git_synch.rb:98:in `block in sync'

Branch 'master' set up to track remote branch 'master' from 'origin'.
Switched to a new branch 'master'
fatal: No such remote: branch
iorad$ git remote -v
branch    develop (fetch)
branch    develop (push)
origin    [email protected]:iorad/iorad.git (fetch)
origin    [email protected]:iorad/iorad.git (push)
@hoatle hoatle added this to the v0.6.0-a5-dev milestone Oct 30, 2018
datphan added a commit to datphan/dev that referenced this issue Oct 30, 2018
@hoatle hoatle changed the title should handle the extension properly with slash / should handle the extension properly when it is within a repo Oct 30, 2018
@hoatle hoatle assigned hoatle and unassigned datphan Oct 30, 2018
@hoatle
Copy link
Member Author

hoatle commented Oct 30, 2018

note: due to the wrong config, the $ git remote -v error is expected, we'll handle this case (validate later by #495)

       git:
          remote:
            origin: [email protected]:iorad/iorad.git
            branch: develop

should be:

       git:
          remote:
            origin: [email protected]:iorad/iorad.git
          branch: develop

hoatle added a commit that referenced this issue Oct 30, 2018
@ #527 | use first extension name
@hoatle hoatle assigned datphan and unassigned hoatle Oct 30, 2018
@hoatle hoatle closed this as completed Oct 30, 2018
@ghost ghost removed the stag:under-verification label Oct 30, 2018
@hoatle hoatle changed the title should handle the extension properly when it is within a repo should handle the extension sync properly when it is within a repo Oct 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants