-
-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AS variable is wrongly set #23102
Comments
Could you share how to reproduce the build failure? |
If only on my own CI:
is what you see near the end of the log. The run with work-around applied: Here you can see:
somewhere in the middle of a huge log. |
I don't know whether setting |
I think someone should just |
I ran full rebuild of the packages and found no difference in setting |
Thank you. |
My conclusion from the rebuild is that forcing a specific AS will break some builds. The existing set up Therefore I propose to close this issue as won't fix. |
-x assembler is optional, so how |
My take is to not to force any command line argument when designate a compiler or assembler for compiling. That should be done by author's Makefile or build system. It has worked for a long time. I let others to chime in first. |
Will do.
That's been my experience as well. |
That's exactly what was expected |
I will leave up the rest of the team to decide whether to merge #23190 rebuild report. The gist is there's no difference. The only other real world example I can find is Gentoo: https://github.com/gentoo/gentoo/blob/master/profiles/features/llvm/make.defaults The drawback is to manually fix exotic build system for some packages which noted by gentoo/gentoo#27087 (comment) Still, I found examples of |
OK, I re-checked if maybe |
Hmm, and actually, how about |
It seems termux sets AS
variable to
aarch64-linux-android-clang
in termux_setup_toolchain_27c.sh script.
But it should set it to:
aarch64-linux-android-clang -c
as otherwise also linker is invoked, leading
to a build failure (in my case).
The text was updated successfully, but these errors were encountered: