support query by id ascending to support synchronization of pending jobs #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xphilipp
commented
Feb 25, 2023
| .take(limit) | ||
| .collect::<StdResult<Vec<_>>>()?; | ||
|
|
||
| let mut jobs = vec![]; |
There was a problem hiding this comment.
also optimized this to do it directly in the map to not copy the whole list again and reiterate it.
0xphilipp
commented
Feb 25, 2023
| let infos = map | ||
| .range(deps.storage, start, None, Order::Ascending) | ||
| .filter(|h| { | ||
| resolve_filters( |
There was a problem hiding this comment.
instead of cloning everything, it could be better to just borrow things. For small structs cloning is better, but not sure about strings etc.
0xphilipp
commented
Feb 25, 2023
| @@ -92,6 +92,7 @@ pub struct QueryJobsMsg { | |||
| pub condition_status: Option<bool>, | |||
| pub start_after: Option<JobIndex>, | |||
| pub limit: Option<u32>, | |||
| pub use_id_order: Option<bool>, | |||
There was a problem hiding this comment.
if this is set to true and no ids provided, the order will be by id ascending
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.