Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow adding custom Domains to environments. #80

Open
4 tasks done
jonpugh opened this issue Aug 10, 2015 · 4 comments
Open
4 tasks done

Allow adding custom Domains to environments. #80

jonpugh opened this issue Aug 10, 2015 · 4 comments

Comments

@jonpugh
Copy link
Member

jonpugh commented Aug 10, 2015

  • Modify Config.php to turn Domains into an array or list: https://github.com/terra-ops/terra-cli/blob/master/src/terra/Config.php#L82
  • Add a command class terra\Command\Environment\EnvironmentDomains: "environment:domains".
  • Add the command class to terra\Console\Application::getDefaultCommands()
  • Add all the Domains to terra\Factory\EnvironmentFactory::getDockerComposeArray()
@jonpugh jonpugh changed the title Allow adding custom URLs to environments. Allow adding custom Domains to environments. Sep 11, 2015
@jonpugh
Copy link
Member Author

jonpugh commented Sep 11, 2015

I've updated the issue with the new plan:

New commands:

terra environment:domains - List all domains attached to an environment.
terra environment:domains add - Add a domain to an environment.
terra environment:domains remove - Remove a domain from an environment.

jonpugh added a commit that referenced this issue Sep 11, 2015
@jonpugh
Copy link
Member Author

jonpugh commented Sep 11, 2015

Ok, this seems to work!!

I'd like to add more features in the future like DNS checks, but I think it's working well enough to close the issue.

@jlyon: Check it out and let me know what you think!!

@jlyon
Copy link
Contributor

jlyon commented Sep 11, 2015

Awesome! I'll take a look today

@jlyon
Copy link
Contributor

jlyon commented Sep 11, 2015

This works great for me after I added domains: {} to each environment in ~/.terra/terra. This is really awesome. Nice work!

Note for others, "add" comes after app and environment in the command:

terra  environment:domains [<app_name>] [<environment_name>] [<action>] [<domain>]

so:

terra  environment:domains drupal dev add dev-drupal.example.com

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants